Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

favicons not displayed after import of bookmarks from Safari / Chrome #11203

Closed
LaurenWags opened this issue Sep 28, 2017 · 6 comments
Closed
Labels
bug feature/bookmarks feature/importer priority/P4 Minor loss of function. Workaround usually present. wontfix

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 28, 2017

Description

I imported a small amount of bookmarks (7 bookmarks and 2 folders) from Safari. Favicons for the imported bookmarks were not displayed after being imported.

Steps to Reproduce

  1. Have bookmarks set up in safari and verify you can see their favicons. Close safari.
  2. Import bookmarks from Safari.

Actual result:
Favicons were not displayed after import:
screen shot 2017-09-28 at 10 42 15 am

Expected result:
Favicons should be displayed after import of bookmarks.

Reproduces how often: [What percentage of the time does it reproduce?] 100%

Brave Version

about:brave info:
Brave | 0.19.23
OS Release | 16.7.0
Muon | 4.4.25

Reproducible on current live release:
Yes, can reproduce on 0.18.36, back to 0.16.6

Additional Information

cc: @kjozwiak

@darkdh
Copy link
Member

darkdh commented Sep 28, 2017

importer.on('add-favicons' in app/importer.js is not being hit which means muon doesn't emit this event

@LaurenWags LaurenWags changed the title favicons not displayed after import of bookmarks favicons not displayed after import of bookmarks from Safari Sep 28, 2017
@LaurenWags LaurenWags added priority/P4 Minor loss of function. Workaround usually present. and removed priority/P3 Major loss of function. feature/sync labels Sep 28, 2017
@kjozwiak
Copy link
Member

@NejcZdovc is this the same issue that I was experiencing in #10325 (review)? I believe it was fixed in that PR as well but I could be wrong.

@LaurenWags can you see if this is happening in the 0.20.x branch?

@LaurenWags
Copy link
Member Author

@kjozwiak still experiencing this with 0.20.6

@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@bsclifton
Copy link
Member

+1 from @comodoro via #12996

After install and importing bookmarks from Chrome everything imported correctly, but favicons have been the generic grey sheets without image. This is on the bookmarks toolbar as well as the bookmarks menu.

Current Brave 0.20.30, Windows 10.

image

@bsclifton bsclifton changed the title favicons not displayed after import of bookmarks from Safari favicons not displayed after import of bookmarks from Safari / Chrome May 1, 2018
@eljuno
Copy link
Contributor

eljuno commented Jun 19, 2018

+1 from community. Imported from Chrome https://community.brave.com/t/bookmarks-bar-showing-as-a-list/24130?u=eljuno

@rebron rebron removed this from the Backlog (Prioritized) milestone Sep 9, 2018
@rebron rebron added the wontfix label Sep 9, 2018
@rebron
Copy link
Collaborator

rebron commented Sep 9, 2018

Closing and marking wontfix. Reopen if still an issue in brave-core.

@rebron rebron closed this as completed Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/bookmarks feature/importer priority/P4 Minor loss of function. Workaround usually present. wontfix
Projects
None yet
Development

No branches or pull requests

6 participants