Tab colour has weird fade in paint effect when switching

[srirambv]

Description

Tab colour has weird fade in paint effect when switching

Steps to Reproduce

1. Build from master
2. Visit brianbondy.com, tab colour has weird paint effect
3. Open any about page, same weird effect

Actual result:

Expected result:
Should paint entire tab

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave	0.21.0
V8	6.1.534.41
rev	de5f381
Muon	4.4.25

Reproducible on current live release:

No

Additional Information

cc: @cezaraugusto

[luixxiul]

how weird is it?

[srirambv]

Its pretty obvious and doesnt look good. May be not very noticeable in the gif image. Dark tab colour makes it more prominent because of the light tab colour

[srirambv]

Here's a better recording

[luixxiul]

That kind of fading effect is intentional I think. Do you think feel it is too slow or something?

[luixxiul]

This is on macOS. Though it looks not good with this gif image, it actually is rendered naturally.

[srirambv]

Never seen that fade-in effect till now. But its definitely not looking good on Windows. Sometimes the colour paints slow on the close tab button so it looks really bad. may be fade-in from centre towards end would be a good idea rather than fade-in from left that way it evens out the effect on the close button as well

[srirambv]

cc: @jenn-rhim @bradleyrichter

[luixxiul]

If the perf issue was confirmed on Windows globally, we could turn off the fading effect on Windows. We would not have to disable it on macOS as well. CC @cezaraugusto #10691

[cezaraugusto]

it is intentional how it looks now but I'm open for improvements. If there's a "slow" feeling on Windows please let me know. Deferring UX decision to design team.

[srirambv]

Its definitely looks bad on Windows and its quite noticeable and isn't appealing. It definitely needs some rework for Windows

[luixxiul]

It might be well rendered with a better graphic card on board.

[cezaraugusto]

thanks I'm taking let's make it better

[petemill]

Correct me if I'm wrong, but I'm guessing the issue here is the difference in speed fading from the background color, and the background color of the right edge, which is different and changes instantly. The right edge is different because in the current implementation it is used to fade out the text when the title text is too long. This is solved (mostly) by #12565 .

By the way, you can see this even more obviously by slowing down animations in devTools. Open the 'animations' panel, and hit '10%'. Then change active tab, especially between a dark one (like the New Tab page)...

@srirambv is this what you were referring to?:

[srirambv]

Verified on Windows x64

• 0.22.6 e6ff4ea
• libchromiumcontent: 65.0.3325.162
• muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

• 0.22.6 e6ff4ea
• libchromiumcontent: 65.0.3325.162
• muon: 5.1.0

Verified on Ubuntu 10.10 x64

• 0.22.7 8bb7e77
• libchromiumcontent: 65.0.3325.181
• muon: 5.1.1