URL and tab bar do not hide in full screen mode #11463
Comments
|
How do you trigger full screen? I'm trying F11, but it will just maximize the window. What I'm looking for is a way to just show the page on the screen, nothing else, no tab-bar, title-bar, any-other-bar, as well as no bars/panels from the desktop/window manager. |
How about enhancing these options on #11547 (comment) to achieve #6928 (comment)? the menubar will also be able to be hidden (to achieve that we need to figure out how and where to display the menu bar) |
|
|
|
That seems to be almost like fullscreen @luixxiul, although it still shows the menu bar in your example. And I suppose it would also show the windows taskbar and such? Also, it seems that what is described in #11547 would require quite some manual steps to remove everything and put everything back, but perhaps I don't understand it. What I would like is something similar to the F11 key in most other browsers (firefox, chrome, edge). That is, a quick way to maximizes the viewport of the page (to the entire screen) and to minimize distractions. E.g. when reading a long read, or when composing text. Currently F11 maximizes/'demaximizes' the Brave window (at least in Windows). I don't think I ever needed a keyboard shortcut for that, but apparently there is one already in Windows: winkey + arrow up (or arrow down), so F11 for that is superfluous. |
Yes, I understand what you mean. Pushing F11 on Fx hides everything but the webview. The actual blocker for that seems to me is #2775:
I follow the Fx's practice to customize the toolbar. which I now think is irrelevant to the fullscreen option. |
|
Could you tell me what Fx is @luixxiul? The behavior of my Brave installation (0.19.54, Windows 10) is very different from what is described in #2775, and also very different from the screenshot you posted. Almost nothing happens when I press F11. The window maximizes or turns back to a normal window and that's it. But it is hard to spot the difference since the windowed version is almost the same size as the maximized version. See the below two screenshots: Before hitting F11, Brave is not maximized: you can see the black of my desktop wallpaper, and the windowing button (next to the close button on the top right) shows that I can maximize the window. After hitting F11, the windows is now maximized: no wallpaper visible and the windowing button now shows that I can turn the application back to windowed mode. I can go back and forth between those two modes by either: a) hitting F11, b) clicking the window-icon next to the close-icon on the top right, or c) pressing windows-key + up-arrow and windows-key + down-arrow. These all three do almost the same thing (the difference is the size of the window when not maximized). I'd like F11 to be different: not show anything except the page. So where #2775 talks about difficulty of leaving full screen, I have a problem entering full screen. From the screenshot from @satnatantas it seems that they have the same problem. |
|
I see, let me explain: what I mean is that it is quite easy to code to hide everything on F11 mode, but the issue here is that we often forget which key you have to push to go out of the fullscreen mode until you know the browser well. On Firefox the toolbar is displayed when you move your mouse cursor on the top of the monitor, and you can click the caption button to go out of the issue. Without that hint, for new users, sometimes it becomes hard to do so. We could easily imagine that they might think "how to go out the fullscreen mode?" (whether they actually would say so or not). Without solving the usability issue, hiding everything from the fullscreen mode can be an issue for them (not for you; I know you're an advanced user). I myself have noticed that issue. Neither ESC nor Windows key worked and I almost gave up to use the browser at all. Please forget about my screenshot. I found It was irrelevant with the fullscreen option. |
|
Ah thank you @luixxiul, I misunderstood you. I thought that there were all these people using Brave full screen with only minor problems 😃. Other issues seem to indicate that such a full screen mode has indeed existed in the past. E.g. #11558 has a checkbox next to "Test that entering full screen window works View -> Toggle Full Screen. And exit back (Not Esc)." This lead me to conclude that it should be possible to go to full screen mode. Actually toggling full screen mode through the view menu does nothing. You are right, it should be clear how to leave full screen mode. If that's not clear, then it is better to not have a full screen mode at all. I've also been through that, putting something full screen by accident with no clue how to get back. But then we should not check that checkbox in #11558 until it works. And perhaps remove the option from the menu until then. Made me wonder what other browsers do, perhaps we can do something similar:
|
|
Ah, learned something. Pressing F11 or using view->full screen does do something: it does not show the windows task bar. I've always got the windows taskbar to automatically hide (on the right side of the screen), so there was no real visible change for me when going to full screen mode. I only noticed that something was different because the taskbar doesn't unhide when moving the mouse cursor to it in full screen mode. Hence the confusion. So perhaps the checkbox in #11558 is then technically correct, even though the full screen option (as it is now) is irrelevant for me. |
|
I am very afraid to be hallucinating but I was very sure that full screen mode hid all bars when I activated it with F11. If there are good reasons to suppose that I am wrong do not hesitate to do it. If it the case then treat this issue like request for implementing full screen mode without bars (which appear upon hovering the border). |
|
I now understand my eff-up. I did not activate full screen mode on Periscope (the only site which I used in full screen mode) with F11, I used deicated page button instead (for whatever reason). Sorry for confusion. Would still like to see better full screen mode. |
|
Hmm yes, that button on periscope does exactly what I'd want F11 to do. Brave even asks whether it allows the site to go full screen and shows 'press Esc to exit' on top. Youtube can also go full screen, but that'll just show the movie, unlike periscope. So apparently all the necessary functionality for full screen is already in Brave. So it is totally unclear to me why F11 (on any page) does not do the same as that full screen button on periscope. @luixxiul do you know? |
|
+1 I'd also like a feature for tab bar to hide under the url bar and either appears when scrolling upwards or clicking something on the browser. Slightly different to 'Automatically hide the taskbar in desktop mode', perhaps you could allow a fun feature of when it is allowed to hide under the url bar moving the mouse upwards doesn't have to always display the entire bar but also allowing it to be displayed like piano keys, so moving the mouse upwards shows the tab that would originate to wherever you're pointing the mouse and moving right to left displays the tabs like a piano. The reason why I'd like a feature like this would be because there are some occasions where I'd like to take screenshots/vids and I would prefer to keep the numerous tabs that are open private but have no choice but to close every tab and then reopening every single tab and I don't think I have to mention the fact that the bookmaking feature isn't appreciated just yet. Another reason for this feature would be for better screen maximization not just for small screen issues but also the fact it sometimes looks neater so you can concentrate on just the page rather than having numerous titles and different colours presented along a line which can cause distraction. I suppose this could be an added benefit as well given over time more user extensions will be presented and it may be best to have two or three rows, one, for pinned/bookmarked items, one for the tabs and the other for extensions, unless the team have decided to opt for something better. from a design perspective. |
|
+1 to this, it's a very important feature to be able to focus without getting distracted and finding yourself on another website |
|
+1 from community https://community.brave.com/t/what-about-a-real-fullscreen-mode/12096?u=eljuno
|
|
@bsclifton If this is an easy enough change, let's do it soon. |
|
This user really likes true full screen: ; ) |
|
So the desire, to summarize, is to change our current implementation of full-screen (not to be confused with a FS video view) to hide all UI elements with an expanded view of the content area. (no toolbars visible) |
|
I'm using Brave 0.19.147 on windows with the windows taskbar hidden. I just noted that full screen currently results in a smaller viewport than non-full screen. Normal, maximized. Notice that on the right the 'window' seems to extend a bit out of the screen, as can be seen from the arrows on the scrollbar that touch the edge of the screen. The taskbar is hidden on that side of the screen, not sure whether that matters. 'Full screen', now the viewport is slightly smaller. The arrows on the scrollbar are now fully visible. Brave is the very first program where full screen is smaller than non full screen :-). |
|
@hugobuddel looks very much like erratic window size calculation because the scrollbar is slightly cropped on first shot. |
alexwykoff
added
the
priority/P5
|
This problem is probably the only thing keeping me from using Brave, thanks everyone for working on issue. |
|
+1 from Mac user. |
|
+1 from me (Windows 10 user). This is the only thing keeping me from using this as my default browser. Sadly, this issue doesn't seem to have anybody assigned to it. |
|
+1 from Mac use. Though I use it as default now. I really like it. Fingers crossed on this thing getting fixed! Cheers everyone |
|
+1 Mac user. I love brave, but writing in it is a pain. Without full screen I can't concentrate. |
|
I have the same problem on latest release. Key F11 for fullscreen doesn't remove url bar, rest is fullscreen. (Meaning the Windows taskbar gets hidden, meaning fullscreen started) Brave: 0.22.669 |
|
+1 from a Mac user. Really like Brave so far but this is a problem that might cause me to jump back to another browser... Thanks for all the hard work on this project! |
|
+1 from a Mac User |
|
+1 from another Mac user. Brave seems great but not having 'true' full screen (URL and tabs hidden) is almost a (trivial) deal breaker |
|
+1 mac |
|
+1 Ubuntu&Windows&Android |
|
+1 ubuntu |
|
@srirambv is this fixed with Brave Core? |
|
+1 Ubuntu |
|
This will be fixed in Brave-core. Closing as |
srirambv
added
wontfix
fixed-with-brave-core
|
Can we follow the progress of the full screen feature somewhere? Or the process of replacing Muon with Brave Core? This issue is now closed, but full screen does not work yet. Brave-core does not seem to have an issue tracker of its own, so it is not clear what the status of the full screen feature is, or where to discuss it. |
|
We're tracking issues for brave-core in the parent repo: While most work goes here: I believe this issue in particular will be covered with brave-core and isn't planned to be fixed before that is released which is this year within the next few months. You can compare for example to what Chrome does and if you think that behaviour isn't right then you can post an issue on the For cases like this, we're going with the process of adding a |
|
OK, so brave-core will behave more 'Chromium-like' than muon? It's not directly clear from the project descriptions: "Brave Core is a set of changes, APIs, and scripts used for customizing Chromium [..]" and "Muon is a framework that leverages the full power of Chromium [..]". Seeing all the issues this will fix, it seems like a good change, even though you're probably giving something up in the process too. |
and others
Requires #2775 to be fixed
Description
URL and tab bar are not hidden in full screen mode while Windows' task bar gets hidden (i.e. browser is indeed going into full screen mode).
Steps to Reproduce
I cannot get rid of this bug.
Actual result:
Bars are present.
Expected result:
They should not.
Reproduces how often:
Reproducible on my machine 100% of cases.
Brave Version
Brave | 0.19.44
rev | e391af1
Muon | 4.4.28
libchromiumcontent | 61.0.3163.100
V8 | 6.1.534.41
Node.js | 7.9.0
Update Channel | Beta
OS Platform | Microsoft Windows
OS Release | 6.1.7601
OS Architecture | x64
Same on 0.18.36.
Reproducible on current live release:
Yes.
Additional Information
https://imgur.com/a/jbLSt
It worked for few days first. Restart, reboot or installing Brave for different user changes nothing. It is very interesting how can there be any state saved between users which causes this bug. I can provide more information and try to debug this if there are guides about that.Only ever worked if site itself has full screen support and own full screen button, I did not pay attention to that.The text was updated successfully, but these errors were encountered: