Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Selecting "Close" on pinned tabs creates a copy of the tab #11805

Closed
luixxiul opened this issue Nov 6, 2017 · 2 comments
Closed

Selecting "Close" on pinned tabs creates a copy of the tab #11805

luixxiul opened this issue Nov 6, 2017 · 2 comments
Labels
feature/pinned-tabs invalid

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 6, 2017

Description

This is a follow-up to #4063.

Selecting "Close" on pinned tabs creates a copy of the tab.

bug

Steps to Reproduce

  1. Open any page in a new tab (Open https://twitter.com for example)
  2. Pin it
  3. Close it

Actual result:

The copy of the tab is created.

Expected result:

The pinned tab should be closed

Reproduces how often:

Consistently.

Brave Version

about:brave info:

Brave: 0.20.5
V8: 6.2.414.36
rev: 0cc4f80
Muon: 4.5.14
OS Release: 4.9.0-3-amd64
Update Channel: Beta
OS Architecture: x64
OS Platform: Linux
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 62.0.3202.75

Reproducible on current live release:

Additional Information
@luixxiul luixxiul added 0.20.x issue first seen in 0.20.x bug feature/pinned-tabs labels Nov 6, 2017
@luixxiul luixxiul mentioned this issue Nov 6, 2017
Closed
@bsclifton
Copy link
Member

@luixxiul in the recording above, you are picking "Clone", not "Close"

@bsclifton bsclifton added invalid and removed bug labels Nov 6, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 6, 2017

Yes, my bad 😅

@luixxiul luixxiul removed the 0.20.x issue first seen in 0.20.x label Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/pinned-tabs invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luixxiul @bsclifton