Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

YT views from Private Tabs are being placed into ledger #11959

Closed
kjozwiak opened this issue Nov 14, 2017 · 0 comments
Closed

YT views from Private Tabs are being placed into ledger #11959

kjozwiak opened this issue Nov 14, 2017 · 0 comments

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Nov 14, 2017

Test plan

#11961 (comment)


Description

YT video's that are being watched within Private Tabs are being added into the ledger. We don't add websites that have been viewed in Private Tabs, we shouldn't be placing YT views either. This is a privacy issue as the ledger will record which videos have been watched, including the time spent.

Steps to Reproduce

  1. launch brave and enable wallet via about:preferences#payments
  2. once the wallet has been created, open a new Private Tab
  3. visit YT and watch a video for about 20-30s
  4. return to about:preferences#payments and you'll notice the YT view was added into the ledger

Actual result:

YT views within Private Tabs are being added into the ledger.

Expected result:

YT views within Private Tabs shouldn't be counted/added into the ledger.

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.19.91
rev: a308504
Muon: 4.5.15
libchromiumcontent: 62.0.3202.89

Reproducible on current live release:

Nope, YT feature currently not present in the release build.

Additional Information

@srirambv and @LaurenWags also reproduced the issue. Reproducible on all three platforms.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.