Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tab bar doesn't always display correctly after closing tab page #11985

Closed
LaurenWags opened this issue Nov 15, 2017 · 5 comments
Closed

tab bar doesn't always display correctly after closing tab page #11985

LaurenWags opened this issue Nov 15, 2017 · 5 comments
Labels
0.19.x issue first seen in 0.19.x bug feature/tabsbar priority/P4 Minor loss of function. Workaround usually present. regression stale

Comments

@LaurenWags
Copy link
Member

Description

After closing a tab page sometimes the tab bar doesn't display correctly.

Steps to Reproduce

  1. Have at least two tab pages open (I had 3).
  2. Right click on one of the tab pages that does not contain the active tab.
  3. Select Close tab page.

Actual result:
Tab page closes but tab bar isn't refreshed properly.
screen shot 2017-11-15 at 4 02 15 pm

Expected result:
Tab bar should be refreshed properly and show the tab page with the active tab.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.19.93
rev | 25085d0
Muon | 4.5.16

Reproducible on current live release:
no

Additional Information

@LaurenWags LaurenWags added this to the Triage Backlog milestone Nov 15, 2017
@cezaraugusto cezaraugusto added the priority/P4 Minor loss of function. Workaround usually present. label Nov 21, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 15, 2018

@LaurenWags this may be fixed in 0.20.x. Can you please re-test using that version? If it is fixed, let's move it into 0.20.x 😄

@LaurenWags
Copy link
Member Author

Reproduced on both 0.20.16 packaged build and when building 0.20.x from source (rev 54f89bc )

@cezaraugusto
Copy link
Contributor

fair to put it in 0.21.x?

@bsclifton
Copy link
Member

@cezaraugusto SGTM! 😄 👍

@cezaraugusto cezaraugusto modified the milestones: Backlog (Prioritized), 0.21.x (Developer Channel) Jan 19, 2018
@NejcZdovc
Copy link
Contributor

moving into 0.22

@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 14, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@alexwykoff alexwykoff modified the milestones: 0.23.x (Developer Channel), Backlog (Prioritized) Mar 20, 2018
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton added the stale label Sep 1, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.19.x issue first seen in 0.19.x bug feature/tabsbar priority/P4 Minor loss of function. Workaround usually present. regression stale
Projects
None yet
Development

No branches or pull requests

6 participants