Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Incorrect amount deducted from wallet for payment processing #12183

Closed
srirambv opened this issue Dec 5, 2017 · 2 comments
Closed

Incorrect amount deducted from wallet for payment processing #12183

srirambv opened this issue Dec 5, 2017 · 2 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Dec 5, 2017

Description

While verifying #12154 , came across a scenario where the balance is below the minimum BAT balance and if the user claims token, then the amount deducted from wallet for payment processing is wrong

Steps to Reproduce

  1. Build from Fixes add funds dialog #12154
  2. Launch LEDGER_ENVIRONMENT=staging npm run start
  3. Enable payments and add 20 BAT so that its lesser than the min BAT
  4. Change reconcileStamp to older date
  5. Relaunch LEDGER_NO_FUZZING=true LEDGER_VERBOSE=true LEDGER_ENVIRONMENT=staging npm run start
  6. Ensure Next contribution:overdue
  7. Claim tokens so that balance becomes 50
  8. Wait for contribution to be made so that you see the notification
    image
  9. Once the payment is processed amount of 40 BAT is deducted from account when the monthly budget is set at 25BAT

Actual result:
Monthly payment processing amount is incorrectly deducted

Expected result:
Should only deduct amount equal to the monthly set budget

Reproduces how often:
Consistent on Windows

Brave Version

about:brave info:

Brave 0.19.106
rev 7394478
Muon 4.5.16
libchromiumcontent 62.0.3202.94
V8 6.2.414.42
Node.js 7.9.0
Update Channel Release
OS Platform Microsoft Windows
OS Release 10.0.16299
OS Architecture x64

Reproducible on current live release:
Not sure

Additional Information

cc: @mrose17 @evq

@srirambv srirambv added 0.19.x issue first seen in 0.19.x bug feature/rewards initiative/bat-payments priority/P2 Crashes. Loss of data. Severe memory leak. labels Dec 5, 2017
@srirambv srirambv removed the priority/P2 Crashes. Loss of data. Severe memory leak. label Dec 5, 2017
@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Dec 12, 2017
@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 9, 0.21.x (Developer Channel) Dec 20, 2017
@bsclifton bsclifton removed their assignment Jan 2, 2018
@NejcZdovc
Copy link
Contributor

@srirambv is this still a problem?

@srirambv
Copy link
Collaborator Author

Can't reproduce this any more on 0.19.136. Closing for now.

@srirambv srirambv added 0.21.x issue first seen in 0.21.x and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. 0.19.x issue first seen in 0.19.x labels Jan 16, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.