Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

js/lib/request.js should use non-persistent session by default #12469

Closed
diracdeltas opened this issue Jan 3, 2018 · 1 comment · Fixed by #12694
Closed

js/lib/request.js should use non-persistent session by default #12469

diracdeltas opened this issue Jan 3, 2018 · 1 comment · Fixed by #12694
Assignees
@diracdeltas
Labels
QA/no-qa-needed release-notes/include security
Milestone
0.22.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jan 3, 2018 •
edited by luixxiul
Loading

Test plan

#12694 (comment)

currently it uses the default session, which may write data (cache, etc.) to disk. it is better to use a non-persistent session to prevent leaks from private browsing.

no-qa-needed except to test for regressions
@diracdeltas diracdeltas self-assigned this Jan 3, 2018
@diracdeltas diracdeltas added this to the 0.21.x (Developer Channel) milestone Jan 17, 2018
@diracdeltas
Copy link
Member Author

fixed by #12694

@diracdeltas diracdeltas mentioned this issue Jan 30, 2018
Merged
10 tasks
@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/no-qa-needed release-notes/include security
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use non-persistent session for requests by default brave/browser-laptop
2 participants
@diracdeltas @luixxiul