Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add cryptotokenPrivate and device support (hid and usb) for U2F #12507

Closed
bbondy opened this issue Jan 4, 2018 · 7 comments
Closed

Add cryptotokenPrivate and device support (hid and usb) for U2F #12507

bbondy opened this issue Jan 4, 2018 · 7 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jan 4, 2018

Test plan

  1. Build with Add U2F support via cryptotoken extension #10530
  2. Go to https://demo.yubico.com/u2f?tab=register
  3. Make up a username and password and click next
  4. You should be prompted to plug in your u2f key
  5. You will be prompted to touch the sensor on your u2f key
  6. On success you can attempt login using the same username and password
  7. You will be prompted to again plug in / touch the sensor on your u2f key

Original issue description

For tracking:
brave/muon#268

@bbondy bbondy added this to the 0.20.x Hotfix 1 milestone Jan 4, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.20.x Hotfix 2 (Referral Promotion) Feb 6, 2018
@NejcZdovc
Copy link
Contributor

closing as muon PR was merged

@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
@bsclifton
Copy link
Member

@evq can you provide some testing steps (you can edit the top post). Thanks! 😄 👍

@evq
Copy link
Member

evq commented Feb 8, 2018

@bsclifton should I add them here, or edit #10530 ?

@bsclifton
Copy link
Member

@evq here would be great 😄

@evq
Copy link
Member

evq commented Feb 8, 2018

Added, thanks @bsclifton :)

@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Test plan works but still have issues relating to other domain login (#13564)

Verified STR macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Ubuntu 17.10 x64 using the following build:

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Also checked the following websites using Ubuntu 17.10 x64:

@kjozwiak
Copy link
Member

This will appear in the release notes via #518.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.