Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix initial 2000 grants during last promotion #12547

Closed
bsclifton opened this issue Jan 8, 2018 · 1 comment · Fixed by #12548
Closed

Fix initial 2000 grants during last promotion #12547

bsclifton opened this issue Jan 8, 2018 · 1 comment · Fixed by #12548

Comments

@bsclifton
Copy link
Member

bsclifton commented Jan 8, 2018

Description

When we did a promotion using the BAT user-growth-pool (UGP), the first 2000 had a settlement time in seconds instead of milliseconds.

We need to make an update to the bat-client library to include a fix for this situation so that folks can reconcile

@evq
Copy link
Member

evq commented Jan 8, 2018

Test Plan

  1. fresh profile (production)
  2. enable payments and recover a wallet with a grant
  3. visit sites until they show under payments
  4. exit brave
  5. edit ledger-state.json to trigger immediate reconcile (manually update the reconcileStamp to be in the past, e.g. copy the value of bootStamp)
  6. start brave with LEDGER_VERBOSE=true LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true and wait until ledger-state.json contains currentReconcile object
  7. exit brave
  8. open ledger-state.json and write down the value of surveyorId in currentReconcile
  9. edit ledger-state.json and corrupt the value of surveyorId in currentReconcile (e.g. change some letters)
  10. start brave with LEDGER_VERBOSE=true LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true and wait until ledger-state.json the currentReconcile object is updated
  11. when updated the corrupted value should be fixed (restored to the value you noted down earlier)

Note that the reconcile is not expected to succeed since grant redemption is currently disabled - merely having the surveyorId be automatically fixed is sufficient to consider this test plan as passing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.