Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinned Donations Should Always Be Displayed #12584

Closed
jonathansampson opened this issue Jan 10, 2018 · 6 comments
Closed

Pinned Donations Should Always Be Displayed #12584

jonathansampson opened this issue Jan 10, 2018 · 6 comments
Assignees
@ryanml
Labels
design A design change, especially one which needs input from the design team. feature/rewards initiative/bat-payments priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.21.x (Release C...

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Jan 10, 2018 •
edited by bsclifton
Loading

Test plan

See #13097

Description

Pinned-donations may not be revealed in the Brave Payments site-list if they don't meet other criteria.

Steps to Reproduce

  1. Set the threshold to 5 visits, and quality a few domains
  2. Pin one of the domains
  3. Increase the threshold to 10 visits

Actual result:
Pinned donations are no longer shown if they don't meet the visits requirement.

Expected result:
Pinned donations should always be shown.

Reproduces how often:
100%

Brave Version

0.19.131

about:brave info:

Brave: 0.19.131 
rev: da2f34787e51eb44190a7a77249e100fb2368306 
Muon: 4.5.36 
libchromiumcontent: 63.0.3239.132 
V8: 6.3.292.49 
Node.js: 7.9.0 
Update Channel: Release 
OS Platform: Microsoft Windows 
OS Release: 10.0.16299 
OS Architecture: x64

Reproducible on current live release:
Yes
@bsclifton bsclifton added this to the 0.20.x Hotfix 1 milestone Jan 10, 2018
@alexwykoff alexwykoff added design A design change, especially one which needs input from the design team. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Jan 30, 2018
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 2, 0.21.x (Beta Channel) Jan 30, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), Backlog (Prioritized) Jan 30, 2018
@ryanml ryanml mentioned this issue Feb 12, 2018
Merged
10 tasks
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.21.x (Beta Channel) Feb 12, 2018
@NejcZdovc
Copy link
Contributor

closing as #13097 was merged

This was referenced Feb 21, 2018
Closed
Closed
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
@LaurenWags
Copy link
Member

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
@srirambv
Copy link
Collaborator

Broken on 0.21.16
13097

@srirambv srirambv reopened this Feb 27, 2018
@NejcZdovc
Copy link
Contributor

it's not broken, it was not merged in this 0.21 milestone. PR and issues have different milestones. Will merge it now.

@NejcZdovc NejcZdovc removed the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 27, 2018 •
edited
Loading

PR merged into 0.21 b7a5a20

This was referenced Feb 27, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Works on 0.21.17
12584

@kjozwiak kjozwiak mentioned this issue Mar 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
design A design change, especially one which needs input from the design team. feature/rewards initiative/bat-payments priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

No branches or pull requests
8 participants
@jonathansampson @alexwykoff @bsclifton @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski