Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

[hackerone] 313440 (quarantine) #13088

Closed
jumde opened this issue Feb 9, 2018 · 10 comments · Fixed by brave/muon#484
Closed

[hackerone] 313440 (quarantine) #13088

jumde opened this issue Feb 9, 2018 · 10 comments · Fixed by brave/muon#484
Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. muon OS/macOS QA/test-plan-specified release-notes/include security wontfix

Comments

@jumde
Copy link
Contributor

jumde commented Feb 9, 2018

https://hackerone.com/bugs?report_id=313440

@jumde
Copy link
Contributor Author

jumde commented Feb 11, 2018

Verification Steps:

$ xattr ~/Downloads/node-v8.9.4.pkg
com.apple.metadata:kMDItemWhereFroms
com.apple.quarantine

Quarantine flag should be enabled for the file

  • Check if brave updates are functional

@alexwykoff
Copy link
Contributor

@diracdeltas @jumde is this release blocking?

@diracdeltas
Copy link
Member

if possible

@bsclifton
Copy link
Member

bsclifton commented Feb 13, 2018

@jumde @diracdeltas this requires this Muon change, right?
brave/muon#484

If we get the Muon PR merged into 5.0.x, I think we should be good to go 😄

@diracdeltas
Copy link
Member

diracdeltas commented Feb 13, 2018

@bsclifton yup, the muon change will fix the issue. It's opened here so QA has steps to verify it. (In particular, they should verify that the change does not break brave autoupdate)

@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@LaurenWags
Copy link
Member

LaurenWags commented Mar 26, 2018

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Updated from v0.22.6 to v0.22.7 on Win7 x64:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@kjozwiak
Copy link
Member

Specific to mac and the gatekeeper.

@cndouglas
Copy link

+1 from me (#13085). Thanks for fixing!

@bsclifton bsclifton reopened this Apr 13, 2018
@bsclifton
Copy link
Member

bsclifton commented Apr 13, 2018

Reverted to fix #13817

Reverted brave/muon#570 in Muon and #13819 on browser-laptop

@diracdeltas diracdeltas changed the title [hackerone] 313440 [hackerone] 313440 (quarantine) Aug 2, 2018
@diracdeltas diracdeltas added the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Aug 2, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. muon OS/macOS QA/test-plan-specified release-notes/include security wontfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants