Replace Fanboy's Swedish with Frellwit's Swedish Filter for Swedish regional adblock filters

[Jacalz]

New description

This fix was broken by this commit in brave/muon since the new ad-block dep has one new fix but is currently 16 commits behind master! That is why the better ad-block fix for Swedish users are not there yet. Since it sadly got removed from what I see was a mistake 👍 Thus should this commit be merged to master and then the ad-block dep should be updated in Muon 🙂

Test plan

1. Go to about:adblock
2. Verify that it says Frellwit's Swedish and not Fanboy's Swedish for the swedish filter lists
3. Go to Expressen and verify that no ads are shown

Description

Fanboy's Swedish is no longer maintained and has not been maintained for a year now, thus we should replace it with Frellwit's Swedish Filter that is maintained almost every day!
The new filter is way better with blocking ads on Swedish sites and will probably result in a better ad blocking experience for Swedish users.

Initial support is already merged to brave/ad-block with brave-experiments/ad-block@d549e9a now we are just waiting for a new muon build containing the latest ad-block dependency.

See: brave/muon#486

[bsclifton]

The new 0.21.x is still using Muon 4.8.2; I'll move this to 0.22.x (what used to be 0.21.x) which features Muon 5.0 and has the fix needed for this 😄

[Jacalz]

Thanks 🙂 I did not know that 👍

[bsclifton]

Looks like this shipped with 0.21.x (via Muon 4.8.3). Adjusting milestone to match

[Jacalz]

This did not ship with Muon 4.8.3, I have 4.9.3 and it is not in that version. I have tested with 5.x.x and it is in those releases for me... Changing milestone ;)

[Jacalz]

To be honest I dont see it in latest 0.22.x build either right now, but I did in an earlier version 😓

[bsclifton]

@Jacalz can you check the Muon branch used for this, to see if your change is there?
https://github.com/brave/muon/tree/5.1.x+65.0.3325.181

[bsclifton]

@Jacalz do you have steps to test this also? or can you provide the testing support?

[Jacalz]

I see the problem here now why this is not fixed! First I updated it to latest version here then @bridiver changed the ad-block dep here but that commit has not been merged in to brave/ad-block yet and that branch does not have my fix since it is 16 commits behind master 👎

[Jacalz]

The issue has been updated with test plan and the news about what happened @bsclifton 👍

[Jacalz]

First step to fix this is in ad-block and can be found here: brave-experiments/ad-block#94

[Jacalz]

Second step will be to update the ad-block dep in brave/muon but that can only be done once the PR with the fix from @hferreiro has been merged 👍

[bsclifton]

Per @bbondy next steps:

Update the muon DEPS here to the latest rev for ad-block, tracking-protection, hashset-cpp, and bloom-filter-cpp and make sure it builds. Then QAing to make sure it downloads the new DAT file for the .dat file and doesn't try to use the old v3 one

[bsclifton]

Should be fixed with brave/muon#614

Along with that, we should also get Easy Privacy

[Jacalz]

Awesome work guys, thanks for getting this now 👍 Will have a go at testing this as soon as we get a new 0.23.x build 😀

[Jacalz]

After testing around 30 Swedish sites and comparing to the current stable releases, the conclusion is that sites generally have a lot more trackers and ads blocked but a lot of sites show a noticeable speed improvement. 👍 Have not been able to find any regressions and things are looking really smooth 😄

[Jacalz]

No additional testing will be required in my opinion 👍

[kjozwiak]

@Jacalz thanks for going through this and verifying the fix! Really appreciate all your hard work and effort ❤️