Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

import bookmarks doesn't have extension option with html #13372

Closed
LaurenWags opened this issue Mar 2, 2018 · 2 comments
Closed

import bookmarks doesn't have extension option with html #13372

LaurenWags opened this issue Mar 2, 2018 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Per (second) test case c 'Import bookmark from HTML' from #11906 - when importing bookmarks from HTML file the dialog should have an extension option with html

Steps to Reproduce

  1. Menu->Bookmarks->Import Browser Data.. and select HTML file
  2. The default path should be your download path

Actual result:
The dialog does not have an extension option with html.
screen shot 2018-03-02 at 11 36 56 am

Expected result:
The dialog should have extension option with html and the default extension should be html

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.21.654
V8 | 6.5.254.26
rev | bc6272c
Muon | 5.1.3
OS Release | 16.7.0
Update Channel | Beta
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 65.0.3325.88

Reproducible on current live release:
Yes

Additional Information

@LaurenWags LaurenWags added this to the 0.21.x w/ Chromium 65 (Beta Channel) milestone Mar 2, 2018
@bsclifton
Copy link
Member

If I hit the Options button in the bottom left (macOS):
screen shot 2018-03-09 at 10 57 47 am

It shows the extension (as expected):
screen shot 2018-03-09 at 10 57 21 am

On Windows, it works as expected:
screen shot 2018-03-09 at 10 59 43 am

@darkdh is this expected behavior? (having to click Options in order to see the extension that is being filtered). The filter itself is working, you just need to click Options to show it

@darkdh
Copy link
Member

darkdh commented Mar 9, 2018

yes, please click on Options and you can't choose files other than html. so this is correct behavior

@bsclifton bsclifton removed this from the 0.21.x w/ Chromium 65 (Beta Channel) milestone Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants