Don't package extension resources in Brave

[jonathansampson]

Description

While Brave doesn't package extension data, it does package some extension icons. These are shown within the in-browser list of available extensions. These icons, however, should not be packaged with the browser. Instead, they should be downloaded at a later time.

Actual result:
Extension icons are shipped with Brave.

Expected result:
Extension icons are downloaded by Brave during first run.

Brave Version

0.21.19

about:brave info:

Brave: 0.21.19 
V8: 6.5.254.36 
rev: f359e6ed2616360456945bff01bac707895fd651 
Muon: 4.9.2 
OS Release: 10.0.16299 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.162

Reproducible on current live release:
Yes

Additional Information

See

browser-laptop/app/renderer/lib/extensionsUtil.js

Lines 32 to 90 in 49523fa

	const dummyData = [
	{
	id: bitwarden,
	name: 'bitwarden',
	description: 'bitwardenDesc',
	icon: 'img/extensions/bitwarden-128.png'
	},
	// {
	// id: pinterest,
	// name: 'Pinterest Save',
	// description: 'pinterestDesc',
	// icon: 'img/extensions/pinterest-128.png'
	// }
	{
	id: dashlane,
	name: 'dashlane',
	description: 'dashlaneDesc',
	icon: 'img/extensions/dashlane-128.png'
	// }, {
	// id: enpass,
	// name: 'enpass',
	// description: 'enpassDesc',
	// icon: 'img/extensions/enpass-128.png'
	}, {
	id: lastpass,
	name: 'lastpass',
	description: 'lastpassDesc',
	icon: 'img/extensions/lastpass-128.png'
	}, {
	id: onepassword,
	name: '1password',
	description: '1passwordDesc',
	icon: 'img/extensions/1password-128.png'
	}, {
	id: pocket,
	name: 'saveToPocket',
	description: 'saveToPocketDesc',
	icon: 'img/extensions/pocket-128.png'
	},
	{
	id: honey,
	name: 'honey',
	description: 'honeyDesc',
	icon: 'img/extensions/honey-128.png'
	},
	{
	id: metamask,
	name: 'MetaMask',
	description: 'metamaskDesc',
	icon: 'img/extensions/metamask-128.png'
	}
	// {
	// id: metamask,
	// name: 'MetaMask',
	// description: 'metamaskDesc',
	// icon: 'img/extensions/metamask-128.png'
	// }
	// { id: 'vimium' // TBD }
	]

Icons are stored here: https://github.com/brave/browser-laptop/tree/49523fafd9103c3ba378ac7bf4795135387880d4/app/extensions/brave/img/extensions

[tildelowengrimm]

Where should icons be fetched from?

[jonathansampson]

@flamsmark Great question; it is my understanding that we can download from just about anywhere (even a cache of our own creation). But there is, if I'm not mistaken, a conflict in shipping these with the browser bits.

[tildelowengrimm]

I think there are some privacy implications to fetching them from the CWS, the extension developer's site, or from a cache of our own. Either approach makes new pings we need to handle safely.

[bsclifton]

Closing in favor of brave/brave-browser#825