Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bug -- Ctrl+f search bar not functional #13602

Closed
ryanmusante opened this issue Mar 26, 2018 · 11 comments
Closed

Bug -- Ctrl+f search bar not functional #13602

ryanmusante opened this issue Mar 26, 2018 · 11 comments

Comments

@ryanmusante
Copy link

ryanmusante commented Mar 26, 2018

Description

CTRL+F search pops up the search bar however it is not functional.

Steps to Reproduce

  1. CTRL+F
  2. Use search term
  3. No search prompted
    -->
    Actual result:

searchplease

Expected result:
SEARCH TERM: "Please" for example does not work.

Reproduces how often:

What percentage of the time does it reproduce?
---Intermittent

Brave Version

about:brave info:

Please open about:brave, copy the version information, and paste it.

Name Version
Brave 0.21.18
V8 6.4.388.41
rev 580be78
Muon 4.8.2
OS Release 4.15.13-1-MANJARO
Update Channel Release
OS Architecture x64
OS Platform Linux
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Reproducible on current live release:

@btlechowski
Copy link
Contributor

Thanks for reporting.

Can you update your Brave to 0.21.24 and recheck?

@ryanmusante
Copy link
Author

brave-snapshot-bin 0.21.24-1 in AUR. I will update tonight and check and re-post details.

@jonathansampson
Copy link
Collaborator

I am unable to reproduce from my build:

Brave: 0.21.24 
V8: 6.5.254.36 
rev: 19c78a1624118e344852c4c0f44c0d45be841b5f 
Muon: 4.9.3 
OS Release: 10.0.16299 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.162

@kjozwiak
Copy link
Member

I couldn't reproduce the issue under Ubuntu 17.10.1 x64 using the latest BETA:

Brave: 0.22.7 
V8: 6.5.254.41 
rev: 8bb7e77f69bca186429aafda4bc6ba4d82a5de47 
Muon: 5.1.1 
OS Release: 4.13.0-36-generic 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Linux 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

@ryanmusante could you share some more information with us? Which website are you visiting where you're seeing this happen?

@kjozwiak kjozwiak added the needs-info Another team member needs information from the PR/issue opener. label Mar 27, 2018
@ryanmusante
Copy link
Author

Bug seemed only present for sites using forum softwares: PHPBB / Discourse.
It is working without problems with beta.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 3, 2018

@ryanmusante, could it be possible that the data at the bottom still hasn't been loaded/rendered, hence the search functionality not finding it? If you have the entire page/thread loaded and searching isn't working, that's definitely still an issue that we'll need to fix.

@ryanmusante ryanmusante reopened this Apr 4, 2018
@ryanmusante
Copy link
Author

@kjozwiak I'm still testing with the latest git branch and it seems to be working good now. I'll keep posted on any changes

@kjozwiak
Copy link
Member

Awesome! Thanks @ryanmusante, much appreciated!

@bsclifton
Copy link
Member

@ryanmusante is this still happening on our latest build?

@bsclifton bsclifton added this to the 0.22.x Release 3 (Beta channel) milestone Apr 26, 2018
@ryanmusante
Copy link
Author

@bsclifton Problems seems to be fixed from latest release.

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented May 3, 2018

Verified on Windows x64

  • 0.22.702 e4a853d* libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified with macOS 10.12.6 using

  • 0.22.702 e4a853d
  • muon 6.0.7
  • libchromiumcontent 66.0.3359.139

Verified with Mint 18.3 x64 using the following build:

  • 0.22.711 31d6bcc
  • Muon: 6.0.9
  • libchromiumcontent: 66.0.3359.139

@ryanmusante ryanmusante changed the title Ctrl+f search bar not functional Bug -- Ctrl+f search bar not functional Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants