"This site can’t be reached" when saving .torrent files while "Torrent Viewer" disabled

[kjozwiak]

Description

Saving .torrent files while Torrent Viewer is disabled via about:preferences#extensions will produce a This site can’t be reached tab page while the Save as.. prompt is displayed.

Looks like this should have originally been fixed with #8452 but has regressed.

Steps to Reproduce

1. launch 0.22.7 8bb7e77
2. disable torrent viewer via about:preferences#extensions
3. visit https://www.qubes-os.org/downloads/ and click on the Torrent download

You'll notice that the 'Save as..modal will correctly be displayed, but at the same time, you'll receive theThis site can’t be reached` tab.

Actual result:

Expected result:

User should be prompted the Save as... modal but shouldn't be receiving the This site can’t be reached tab.

Reproduces how often:

100% reproducible using the STR mentioned above.

Brave Version

about:brave info:

Brave: 0.22.7
V8: 6.5.254.41
rev: 8bb7e77
libchromiumcontent: 65.0.3325.181
Muon: 5.1.1
OS Release: 17.4.0
Update Channel: Beta
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2

Reproducible on current live release:

Yes, currently reproducible using 0.21.24 19c78a1 which is the latest released version.

Additional Information

• 0.19.147 f1b90a3 - Reproduced
• 0.21.24 19c78a1 - Reproduced
• 0.22.7 8bb7e77 - Reproduced

[bsclifton]

Closing as a duplicate of #10767