Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinning session tab opens a newtab #13731

Closed
LaurenWags opened this issue Apr 4, 2018 · 2 comments
Closed

pinning session tab opens a newtab #13731

LaurenWags opened this issue Apr 4, 2018 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

If you drag a session tab out into its own window and try to pin it, the tab doesn't pin and a new tab (with the same session #) opens in the original window.

Steps to Reproduce

  1. Launch 0.22.103 with a clean profile
  2. Open a session 1 tab and navigate to a site (I used twitter)
  3. Open a session 2 tab and navigate to a site (I used twitter)
  4. Drag the session 2 tab out into its own window.
  5. Try to pin the session 2 tab

Actual result:
session 2 tab is not pinned, a new tab is opened in the original window:
sessiontabs-pin

Expected result:
session 2 tab should be pinned
sessiontabs-pin02213

Reproduces how often:
easily

Brave Version

about:brave info:
0.22.103

Reproducible on current live release:
no

Additional Information

@LaurenWags LaurenWags added bug feature/session-tabs 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch labels Apr 4, 2018
@LaurenWags LaurenWags added this to the 0.22.x Release 2 (Beta Channel) milestone Apr 4, 2018
@petemill
Copy link
Member

petemill commented Apr 4, 2018

Can't reproduce on current dev so I think this will be fixed in the next build. Let's verify when that is available.

@btlechowski
Copy link
Contributor

btlechowski commented Apr 5, 2018

Verified Win7 x64 v0.22.105

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.109 5e4846e
  • libchromiumcontent: 65.0.3325.181
  • muon: 6.0.3

Verified on Ubuntu 17.10 x64
0.22.703 903b8d0
libchromiumcontent 66.0.3359.139
muon: 6.0.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants