Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reverted quarantine feature for macOS #13826

Closed
bsclifton opened this issue Apr 13, 2018 · 3 comments
Closed

Reverted quarantine feature for macOS #13826

bsclifton opened this issue Apr 13, 2018 · 3 comments
Assignees
@bsclifton
Labels
OS/macOS QA/checked-macOS QA/test-plan-specified release-notes/include
Milestone
0.22.x Release 2

Comments

@bsclifton
Copy link
Member

Companion issue to #13817

Test plan

  1. Download https://nodejs.org/dist/v8.9.4/node-v8.9.4.pkg
  2. Open terminal and run xattr node-v8.9.4.pkg
  3. Quarantine flag (com.apple.quarantine) should NOT be present
@bsclifton bsclifton added this to the 0.22.x Release 2 milestone Apr 13, 2018
@bsclifton bsclifton self-assigned this Apr 13, 2018
@bsclifton
Copy link
Member Author

bsclifton commented Apr 13, 2018 •
edited
Loading

Manually created macOS build

  1. git checkout 0.22.x-promo
  2. npm run build-package
  3. cd Brave-darwin-x64/
  4. manually removed key LSFileQuarantineEnabled and value true from the following files using vim:
Brave.app/Contents/Frameworks/Brave Helper NP.app/Contents/Info.plist
Brave.app/Contents/Frameworks/Brave Helper.app/Contents/Info.plist
Brave.app/Contents/Frameworks/Brave Helper EH.app/Contents/Info.plist
Brave.app/Contents/Info.plist
  1. Build package and passed proper signing parameters
  2. Run upload.py

@bsclifton
Copy link
Member Author

Fixed binaries uploaded - see https://github.com/brave/browser-laptop/releases/tag/v0.22.19dev

@LaurenWags
Copy link
Member

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.20 031ef46
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

@bsclifton bsclifton changed the title Revert quarantine feature for macOS Reverted quarantine feature for macOS Apr 16, 2018
@LaurenWags LaurenWags mentioned this issue Apr 17, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
OS/macOS QA/checked-macOS QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x Release 2
Development

No branches or pull requests
2 participants
@bsclifton @LaurenWags