Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Links that are opened from Private Tabs in a new tab should also open in Private Tabs. #139

Closed
bbondy opened this issue Jan 11, 2016 · 5 comments
Closed

Links that are opened from Private Tabs in a new tab should also open in Private Tabs. #139

bbondy opened this issue Jan 11, 2016 · 5 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jan 11, 2016

No description provided.

@diracdeltas
Copy link
Member

I think tabs opened via a shortcut or menu item when the active tab is private should also be private by default.

@diracdeltas diracdeltas mentioned this issue Jan 15, 2016
Merged
@bbondy
Copy link
Member Author

bbondy commented Jan 15, 2016

Don't think I agree for shortcuts and menu items because if only 1 tab that is private you are stuck in private mode for everything even know we have per tab private mode. I do agree with links from within private tabs though.

@diracdeltas
Copy link
Member

Don't think I agree for shortcuts and menu items because if only 1 tab that is private you are stuck in private mode for everything even know we have per tab private mode.

good point

@bridiver
Copy link
Collaborator

This might "just work" for most links with the latest electron updates. Haven't tested it though

@bbondy
Copy link
Member Author

bbondy commented Jan 22, 2016

Fixed here:
738a238

@bbondy bbondy closed this as completed Jan 22, 2016
@snyk-bot snyk-bot mentioned this issue Aug 14, 2020
Open
This was referenced Sep 15, 2021
Open
Open
Open
This was referenced Apr 7, 2022
Open
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bridiver @diracdeltas @bbondy