You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Selecting 'File > Share' from the menu bar when there aren't any open windows throws an error in the terminal but does not seem to affect the application (app doesn't hang, crash, etc).
Steps to Reproduce
Launch Brave from the terminal.
Close any open windows, but ensure Brave is still running.
Select File > Share
Actual result:
Error in terminal:
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Cannot read property 'get' of undefined
at simpleShareActiveTab (/Applications/Brave.app/Contents/Resources/app.asar/app/browser/share.js:33:52)
at shareReducer (/Applications/Brave.app/Contents/Resources/app.asar/app/browser/reducers/shareReducer.js:23:15)
at reducers.reduce (/Applications/Brave.app/Contents/Resources/app.asar/js/stores/appStore.js:191:24)
at Array.reduce (<anonymous>)
at applyReducers (/Applications/Brave.app/Contents/Resources/app.asar/js/stores/appStore.js:189:68)
at handleAppAction (/Applications/Brave.app/Contents/Resources/app.asar/js/stores/appStore.js:253:16)
at callbacks.forEach (/Applications/Brave.app/Contents/Resources/app.asar/js/dispatcher/appDispatcher.js:107:7)
at Array.forEach (<anonymous>)
at AppDispatcher.dispatchToOwnRegisteredCallbacks (/Applications/Brave.app/Contents/Resources/app.asar/js/dispatcher/appDispatcher.js:106:20)
at AppDispatcher.dispatchInternal (/Applications/Brave.app/Contents/Resources/app.asar/js/dispatcher/appDispatcher.js:132:10)
@LaurenWags looks like it's working on my end as well 👍 Ensured that the menu items under Share are being disabled when there's no windows opened but the Brave process is still running. Also made sure that each menu was re-enabled and worked once there was a window opened.
Checked on macOS 10.13.3 using the following build:
Test plan
See #13933
Description
Selecting 'File > Share' from the menu bar when there aren't any open windows throws an error in the terminal but does not seem to affect the application (app doesn't hang, crash, etc).
Steps to Reproduce
Actual result:
Error in terminal:
Expected result:
No error in terminal.
Reproduces how often:
easily
Brave Version
about:brave info:
Brave | 0.22.667
V8 | 6.6.346.24
rev | 0433b26
Muon | 5.2.6
OS Release | 16.7.0
Update Channel | Release
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 66.0.3359.117
Reproducible on current live release:
yes, reproduces on 0.22.22
Additional Information
Found by @kjozwiak
The text was updated successfully, but these errors were encountered: