Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Find in page does not highlight nor jump to the searched word #13943

Closed
btlechowski opened this issue Apr 25, 2018 · 7 comments
Closed

Find in page does not highlight nor jump to the searched word #13943

btlechowski opened this issue Apr 25, 2018 · 7 comments

Comments

@btlechowski
Copy link
Contributor

btlechowski commented Apr 25, 2018

Steps to Reproduce

  1. Restart Brave (Important)
  2. Open about:welcome
  3. Open Find on page
  4. Search 'extensions'
  5. Go forward with the search till you jump back to the beginning

Actual result:
The searched words are not highlighted
Find in page does not jump to the searched word
image

After pressing ESC or resizing the window:
-the highlighted words are shown
-cannot scroll
-find in page does not jump to the searched word

Expected result:
The searched words are highlighted
Find in page jumps to the searched word
image

Reproduces how often:
100%

Brave Version

Brave: 0.22.109 
V8: 6.5.254.41 
rev: 5e4846eb66981a0b7b283ddf7d65a2721641f87d 
Muon: 6.0.3 
OS Release: 6.1.7601 
Update Channel: Beta 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

Also reproducible on Linux

Additional Information

Related to #13732 #13931

cc @petemill @bsclifton @LaurenWags @kjozwiak @srirambv

@btlechowski btlechowski added regression feature/findbar 0.22.x-single-webview Issue first seen on single-webview build against v0.22.x branch labels Apr 25, 2018
@btlechowski btlechowski added this to the 0.22.x Release 3 (Beta channel) milestone Apr 25, 2018
@LaurenWags
Copy link
Member

Could not reproduce on macOS (even using a fresh profile)

@diracdeltas
Copy link
Member

I have seen this occasionally in 0.22.x before c66 on macos

@diracdeltas
Copy link
Member

NVM, the bug I saw was where it would show 0 matches even though there were definitely some matches. The screenshot above shows that it correctly identifies the number of matches.

@petemill
Copy link
Member

petemill commented May 1, 2018

Need to wait for the next build (0.22.701) to check on Windows

@bsclifton
Copy link
Member

Verified this works great on Windows 10 x64 with latest build (0.22.702) 👍

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented May 3, 2018

Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent: 66.0.3359.139
  • muon: 6.0.7

Verified on Mint 18.3 x64 using the following build:

  • 0.22.711 31d6bcc
  • Muon: 6.0.9
  • libchromiumcontent: 66.0.3359.139

@kjozwiak
Copy link
Member

kjozwiak commented May 9, 2018

@diracdeltas the match case issue was fixed in #14019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants