Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Corrupted seed doesn't show overlay but shows abandon as recovery codes #13980

Closed
srirambv opened this issue May 1, 2018 · 5 comments
Closed
Assignees

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 1, 2018

Description

Corrupted seed doesn't show overlay but shows abandon as recovery codes

Steps to Reproduce

  1. Enable payments and close browser after wallet is created
  2. Edit ledger-state.json file and change all seed value to 0
  3. Relaunch browser, payments-> advance settings -> Backup wallet , shows abandon text , payments doesn't show corrupted overlay

Actual result:
image

Expected result:
Should show the corrupted wallet overlay

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.22.669
V8 6.6.346.24
rev 6cda2e8
Muon 5.2.7
OS Release 10.0.16299
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.117

Reproducible on current live release:
Yes

Additional Information

@srirambv srirambv added this to the 0.22.x Release 3 (Beta channel) milestone May 1, 2018
@srirambv
Copy link
Collaborator Author

srirambv commented May 1, 2018

image

importing this recovery key fails.

@LaurenWags
Copy link
Member

LaurenWags commented May 1, 2018

I did not get the wallet overlay for corrupted seed on 0.22.669 when following these steps:

  1. Enable payments and close browser after wallet is created
  2. Edit ledger-state.json file and change the keyinfo section to look like this per When detecting a corrupted seed #13424 (comment):
    "keyinfo": {
    "seed": {
    "0": 0,
    "1": 0
    }
  3. Relaunch browser go to payments --> payments doesn't show corrupted overlay
  4. Furthermore, when I go to the gear icon and try to view my words, all backup words are displayed even though my ledger-state.json file shows keyinfo as above.

@jasonrsadler
Copy link
Contributor

Same on master

Brave: 0.24.0
V8: 6.5.254.41
rev: ca83ee3
Muon: 5.1.2
OS Release: 17.5.0
Update Channel:
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 65.0.3325.181

@NejcZdovc
Copy link
Contributor

This regressed, when we added support for bip39

@NejcZdovc
Copy link
Contributor

Closing this issue as setting seed values to 0 is not a broken seed. But I created new issue based on @LaurenWags report #14001

@NejcZdovc NejcZdovc removed this from the 0.22.x Release 3 (Beta channel) milestone May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants