Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

not possible to change uphold fingerprinting setting #14204

Closed
diracdeltas opened this issue May 21, 2018 · 6 comments
Closed

not possible to change uphold fingerprinting setting #14204

diracdeltas opened this issue May 21, 2018 · 6 comments

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 21, 2018

Test plan

  1. go to uphold.com
  2. open shields
  3. try to change the setting from 'Allow all fingerprinting' to something else
  4. change should take effect

Original issue description

tested on 9f02082

STR, tested with a clean session store:

  1. go to uphold.com
  2. open shields
  3. try to change the setting from 'Allow all fingerprinting' to something else
  4. notice it can't be changed

Related: #14158

@srirambv
Copy link
Collaborator

srirambv commented May 22, 2018

Verified on Windows x64 with
* 0.22.718 11dcd19
* muon 6.0.12
~* libchromiumcontent 66.0.3359.170~~

Seeing two exceptions added for uphold when changing shields settings
uphold

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 22, 2018

@srirambv this was not released yet, was merged just few hours ago

@LaurenWags
Copy link
Member

LaurenWags commented May 23, 2018

Verified with macOS 10.12.6 using

  • 0.22.719 a9e0956
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Windows x64 with

  • 0.22.719 a9e0956
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Ubuntu 17.10 x64

  • 0.22.719 a9e0956
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

@srirambv
Copy link
Collaborator

Little confused about the expected and actual behaviour. Expected behaviour in steps mentions that user should not be able to change fingerprint settings but actual behaviour is its possible. Here's the recording on latest preview build
uphold

@srirambv srirambv reopened this May 23, 2018
@bsclifton
Copy link
Member

@srirambv my bad on not including test steps here- user should always be able to change the settings. It should just be defaulted to Allow all fingerprinting. The bug was that it was not changeable

@bsclifton
Copy link
Member

Steps added! Re-closing issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.