Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Include EasyPrivacy by default #14476

Closed
bbondy opened this issue Jun 20, 2018 · 2 comments
Closed

Include EasyPrivacy by default #14476

bbondy opened this issue Jun 20, 2018 · 2 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jun 20, 2018

@darkdh just updated the DEPS to point to the new adblock which has EasyPrivacy by default.

CC @kjozwiak @srirambv @LaurenWags

Testing notes:
This new version uses adblock v4 format. The new ad-block v4 lib is not compatible with the old v3 DAT file which gets downloaded to the profile directory for regional DAT files and the default ad-block file ABPFilterParserData.dat.

Please make sure that profiles which already have the old v3 .dat file gets overwritten for both ABPFilterParserData.dat and for regional list .DAT files (which have a UUID for the filename) get upgraded. If it tries to use the old DAT file with the new library, then it will crash so this needs explicit testing.

@srirambv
Copy link
Collaborator

srirambv commented Jun 22, 2018

Verified on Windows 10 x64 using

  • 0.23.12 - 88f6f07
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS (@kjozwiak and @LaurenWags) using

  • 0.23.19 178c3fb
  • Muon 7.1.3
  • libchromiumcontent 67.0.3396.87
Went through the following test case when verifying the above:

* visited a few media websites where there's a lot of ads using `0.22.810` (also logged into a few websites)
* enabled a few regional blocklists via `about:adblock`
* Went into brave profile folder and noticed the following files:  `ABPFilterParserData.dat`, `1088D292-2369-4D40-9BDF-C7DC03C05966.dat`, `7DC2AC80-5BBC-49B8-B473-A31A1145CAC1.dat` & `6A0209AC-9869-4FD6-A9DF-039B4200D52C.dat`
* noted the size of each those files and made a copy to compare after updating

Updated to `0.23.19`and ensured that:

* files mentioned above look updated (size changed)
* loaded a bunch of websites and ensured that blocking as still working (English/Polish/Russian)
* relaunched the browser a few times to make sure there's no crashes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.