Feature request: remove pages from history via the URL bar

[snird]

What:
Removing a page from history by hovering (or marking with arrow keys) the page in the URL bar suggestions, and pressing the DEL key.

Why:
Sometimes, while writing in the URL bar, there is a page we want to remove from history.
This is common behavior in other browsers (Firefox, Chrome..)

I know the changes should be on the URL bar suggestions component: https://github.com/brave/browser-laptop/blob/master/js/components/urlBarSuggestions.js
But I couldn't find the code responsible for sites history, and try to make them talk. Can someone give me a pointer?

[luixxiul]

@bbondy please give him a hint :-)

[bbondy]

History items there are stored in the application state sites list. They are the items with no tags.
I think you'd need to implement js/state/siteUtil's removeSite so when it is called with no tag, and it has no tags left, then it removes the site.

appActions.removeSite is what needs to be called.

[luixxiul]

I think this has been implemented. Correct me if I am wrong /cc: @bbondy

[bbondy]

yep we have this