Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Feature request: expose the options to disable/enable Tor #14603

Closed
johnpwarren opened this issue Jun 29, 2018 · 9 comments
Closed

Feature request: expose the options to disable/enable Tor #14603

johnpwarren opened this issue Jun 29, 2018 · 9 comments

Comments

@johnpwarren
Copy link

Description

I've run into the problem that on some networks I use Tor is banned, but there is no easy configuration to turn off Tor. There is an error popup that shows up when trying to open a private tab that gives an option to turn off Tor but this really seems like it belongs in the preferences.

Stretch goal on this would be to enable Tor in shields so you can have site by site control.

Steps to Reproduce

  1. Run Brave on a network that blocks Tor
  2. Wait 5 minutes
  3. Explain to the CyberDefense guys who came to your desk that it's just some new hotshot browser trying to do right

Brave Version

about:brave info:

Name Version
Brave 0.23.19
V8 6.7.288.46
rev 178c3fb
Muon 7.1.3
OS Release 17.6.0
Update Channel Release
OS Architecture x64
OS Platform macOS
Node.js 7.9.0
Tor 0.3.3.7 (git-035a35178c92da94)
Brave Sync v1.4.2
libchromiumcontent 67.0.3396.87

Reproducible on current live release:
Yes

Additional Information

Tor is a great feature, I'd just like more control over it.

@srirambv
Copy link
Collaborator

Thinks this will be fixed by #12989. cc: @riastradh-brave

@johnpwarren
Copy link
Author

@srirambv Thanks! A temporary fix for me was to kill the tor daemon in the CLI

killall "tor"

@user18x
Copy link

user18x commented Jun 30, 2018

Can i disable tor? Kill a process isn't the best way!

@davidtemkin
Copy link

@johnpwarren Wouldn't lazy-loading Tor fix this? I.e., rather than add a new preference, we don't start the Tor process until/unless user invokes a Tor private tab.

@riastradh-brave
Copy link
Contributor

#12989 won't fix this -- it will just provide another way to reach the Tor network if the default one doesn't work. Deferring and/or configuring tor startup is under discussion.

@johnpwarren
Copy link
Author

johnpwarren commented Jul 2, 2018

@davidtemkin I would assume that would be correct. Still, having detailed control over Tor would be more desirable. My experience was actually coming into the office in the morning and learning about Tor traffic from my workstation from the aforementioned CyberDefense guys. I could replicate it by killing the Tor process, stopping and starting Brave. I haven't checked yet to see if Brave stops the process on exit yet.

@johnpwarren
Copy link
Author

Also, it's probably not a good idea for browser updates to happen over Tor (I am now not the only person in the office who has ticked off the CyberDefense guys [ tor traffic laptop-updates.brave.com]).

@diracdeltas
Copy link
Member

diracdeltas commented Jul 5, 2018

Removing this from the milestone since #14617 will disable Tor until the user explicitly opens a Tor tab.

@bsclifton
Copy link
Member

Closing in favor of brave/brave-browser#454

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants