Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

editable wallet name field disappearing #14906

Closed
kjozwiak opened this issue Aug 2, 2018 · 0 comments
Closed

editable wallet name field disappearing #14906

kjozwiak opened this issue Aug 2, 2018 · 0 comments
Labels
bug in mist this bug is present in the eth-wallet app that brave integrates bug feature/ETH-Wallet priority/P4 Minor loss of function. Workaround usually present. QA/test-plan-specified release-notes/exclude reverted
Milestone

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Aug 2, 2018

Description

When you're editing the wallets name via the editable field, the entire field disappears when you select the entire name, press delete via the keyboard and move focus away from the editable field. When this happens, you'll need to click back on Wallets which will rename the wallet UNAMED. If you click on the wallet, the field will be back and you can try editing it again.

Steps to Reproduce

  1. launch a version of brave that has ETH Wallet (currently using Eth-wallet rebased #14734)
  2. enable ETH Wallet using about:preferences#ethwallet and restart the browser
  3. create a new wallet via New ETH Wallet
  4. once the new wallet has been created, click on the wallet
  5. click on the editable field where the wallet name is displayed, select all the text and press delete via the keyboard (you should see the field disappear but can still see the pencil)
  6. click anywhere on the page so you remove focus from the editable field and you'll notice the field has disappeared

Actual result:

screen shot 2018-08-01 at 10 57 19 pm

Expected result:

The editable wallet name field shouldn't be disappearing.

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.25.0 
V8: 6.7.288.46 
rev: 200494df265755df5a4d391a50f9cddabd5c1b1e 
Muon: 7.1.6 
OS Release: 17.7.0 
Update Channel:  
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 67.0.3396.103

Reproducible on current live release:

No, not reproducible in the current live release as this feature hasn't been released.

Additional Information

@kjozwiak kjozwiak added this to the 0.23.x ETH Wallet milestone Aug 2, 2018
@tildelowengrimm tildelowengrimm added the priority/P4 Minor loss of function. Workaround usually present. label Aug 2, 2018
@Slava Slava added the bug in mist this bug is present in the eth-wallet app that brave integrates label Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug in mist this bug is present in the eth-wallet app that brave integrates bug feature/ETH-Wallet priority/P4 Minor loss of function. Workaround usually present. QA/test-plan-specified release-notes/exclude reverted
Projects
None yet
Development

No branches or pull requests

4 participants