Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add bookmark should change to remove bookmark in the main menu for bookmarked page. #172

Closed
bbondy opened this issue Jan 16, 2016 · 3 comments
Closed

Add bookmark should change to remove bookmark in the main menu for bookmarked page. #172

bbondy opened this issue Jan 16, 2016 · 3 comments
Assignees
@diracdeltas
Labels
feature/bookmarks

Comments

@bbondy
Copy link
Member

bbondy commented Jan 16, 2016

No description provided.

@bbondy bbondy changed the title [1] Add bookmark should change to remove bookmark in the main menu for bookmarked page. Add bookmark should change to remove bookmark in the main menu for bookmarked page. Jan 16, 2016
@diracdeltas
Copy link
Member

I left it the way it is because Chrome's behavior is to just show the bookmark popup if "add bookmark" is clicked on a page that is already bookmarked. not sure if we want to do that long-term

@bbondy
Copy link
Member Author

bbondy commented Jan 16, 2016

possibly that'll be the final UX but seems like a bug currently with our current UI.

@diracdeltas
Copy link
Member

k will fix

@diracdeltas diracdeltas mentioned this issue Jan 19, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/bookmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@diracdeltas @bbondy @luixxiul