Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Middle click on links in bookmarks toolbar should open them in a new tab #1724

Closed
bsclifton opened this issue May 13, 2016 · 8 comments · Fixed by #1861
Closed

Middle click on links in bookmarks toolbar should open them in a new tab #1724

bsclifton opened this issue May 13, 2016 · 8 comments · Fixed by #1861
Assignees
Milestone

Comments

@bsclifton
Copy link
Member

Doing a middle click currently turns the curson into a scroll mode icon and does not open the link

Here's a screen cap of the bookmarks toolbar with a link highlighted that I should be able to middle click
2016-05-13

@bbondy
Copy link
Member

bbondy commented May 13, 2016

fairly sure I added support for this a while back but I don't have a mouse connected at the moment to test. Possibly a newer issue or perhaps only with some mice?

@bsclifton
Copy link
Member Author

bsclifton commented May 13, 2016

Could very well be a newer issue, I don't remember if it used to work. Can anyone else confirm? cc: @luixxiul

This does work as expected if I hold control and click. Should just be a matter of matching that behavior

@bbondy
Copy link
Member

bbondy commented May 13, 2016

just tried in a vm with a mouse attached and it's working for me.

@bsclifton
Copy link
Member Author

Issue may be specific to Windows 10; will need to dig in more to understand

@luixxiul
Copy link
Contributor

Yes, confirmed on Windows 10.

@bbondy
Copy link
Member

bbondy commented May 13, 2016

ok this was probably always broken on windows 10 but when I fixed it only worked on pre win10 (possibly just for win7)

@luixxiul
Copy link
Contributor

FYI this seems to be specific to Windows 10 as this is not producible on Ubuntu 14.04.

@bsclifton
Copy link
Member Author

bsclifton commented May 22, 2016

Checking this out now... it works fine on links, but not when they're nested in a folder (which is a ContextMenu object).

Middle click (when inside a folder) isn't generating a trigger event. Right click generates a "onContextMenu" event. Need to understand what's up w/ middle click and what's dropping it. It's being treated like the middle click is happening on the page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants