Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Google maps interferes with the "create new private tab" key combination #1867

Closed
kanatzidis opened this issue May 22, 2016 · 6 comments
Closed

Comments

@kanatzidis
Copy link

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
While on Google Maps, I tried to open a new private tab using Cmd-Shift-P. Rather than open a new tab, it registered as a print command.

Expected behavior:
It should open a new private tab.

  • Platform (Win7, 8, 10? OS X? Linux distro?):
    OS X 10.11.4
  • Brave Version:
    0.10.0
  • Steps to reproduce:
    1. Navigate to https://maps.google.com
    2. Press Cmd-Shift-P
    3. Observe
@luixxiul
Copy link
Contributor

luixxiul commented May 22, 2016

Confirmed. I think this is related with #1408

@diracdeltas
Copy link
Member

Similar bug in Firefox: cmd+shift+p does nothing in google maps but it opens a private window otherwise. we could switch to cmd+shift+n for private tabs like chrome does, but we were going to reserve that shortcut for new private window.

@kanatzidis
Copy link
Author

kanatzidis commented May 23, 2016

I like Cmd-Shift-N for private window, not sure it's worth screwing around too much with UI/UX just to make one website work. It's not too inconvenient to work around this.

I didn't mind Cmd-Opt-T, why did you switch away from that? If that's not going to get assigned to something else it could be added back as an alternative key combo?

Since this also happens in firefox I'd personally be inclined to say "screw it, won't fix", but I've never made anything as good as Brave so what do I know.

@diracdeltas
Copy link
Member

I didn't mind Cmd-Opt-T, why did you switch away from that? If that's not going to get assigned to something else it could be added back as an alternative key combo?

cmd+opt+t is used for a Romanian alphabet letter on Windows, IIRC. There is an issue for supporting keyboard shortcuts: #1374

@cndouglas
Copy link

cndouglas commented Jun 1, 2016

This problem also occurs when writing a comment on a GitHub (github.com) issue.

@bsclifton
Copy link
Member

Shortcut was changed to Cmd+Shift+N at some point

@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants