Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show the URL in the location bar for invalid URLs (instead of about:error) #2025

Closed
bbondy opened this issue Jun 1, 2016 · 5 comments
Closed

Show the URL in the location bar for invalid URLs (instead of about:error) #2025

bbondy opened this issue Jun 1, 2016 · 5 comments
Labels
feature/URLbar QA/checked-macOS QA/checked-Win64 release-notes/include
Milestone
0.18.x Release

Comments

@bbondy
Copy link
Member

bbondy commented Jun 1, 2016 •
edited
Loading

It's currently pretty annoying when you type a URL for a site but you have 1 letter that is wrong.
Normally you can go to the URL bar and change the 1 letter typo.

But for us it shows about:error.

Test case:
Go to a domain which isn't real like fdafadsfadsfasdfadsfadsfdsfsadfdsa.com
Check the URL bar, it shouldn't say about:error

Test case 2:
Disconnect internet
Go to a valid url
Check the URL bar, it shouldn't say about:error
@bbondy bbondy added this to the 0.10.2dev milestone Jun 1, 2016
@bbondy bbondy mentioned this issue Jun 4, 2016
Closed
@asbjornu
Copy link

asbjornu commented Jun 7, 2016

I hope the fix for this will affect about:error showing for network errors and all other types of errors leading to the page not being displayed too.

@bbondy bbondy closed this as completed in f3f2069 Jun 13, 2016
@sanderaarts
Copy link

Issue seems to be back: URL is replaced with about:error again.

screen shot 2016-12-19 at 12 13 31
Brave 0.12.15 on OS X Yosemite (10.10.5)

@bsclifton
Copy link
Member

Thanks for the heads up @sanderaarts; this is definitely an issue

Reopening...

@bsclifton bsclifton reopened this Dec 19, 2016
@bsclifton bsclifton removed this from the 0.10.4dev milestone Dec 19, 2016
@bsclifton bsclifton changed the title Show the URL in the location bar for invalid URLs Show the URL in the location bar for invalid URLs (instead of about:error) Dec 19, 2016
@bsclifton bsclifton mentioned this issue Jul 19, 2017
Closed
@bsclifton bsclifton marked this as a duplicate of #2302 Jul 19, 2017
@bsclifton bsclifton mentioned this issue Jul 19, 2017
Closed
@bsclifton
Copy link
Member

bsclifton commented Jul 19, 2017 •
edited
Loading

+1 from @BrendanEich via #2302

His use-case happened when network was offline (ex: turn off wifi)

@bbondy
Copy link
Member Author

bbondy commented Jul 27, 2017

This should actually be fixed with the 0.18.x release.

@bbondy bbondy closed this as completed Jul 27, 2017
@bbondy bbondy added this to the 0.18.x (Beta Channel) milestone Jul 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/URLbar QA/checked-macOS QA/checked-Win64 release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

No branches or pull requests
7 participants
@asbjornu @bbondy @alexwykoff @luixxiul @sanderaarts @cezaraugusto @bsclifton