Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

windows installer places Brave in "Brave Inc" folder instead of "Brave" or "Brave Software" #2061

Closed
bridiver opened this issue Jun 3, 2016 · 9 comments · Fixed by #8060
Closed

Comments

@bridiver
Copy link
Collaborator

bridiver commented Jun 3, 2016

Test plan

#8060 (comment)

Original issue description

cc @aekeus @bbondy @bradleyrichter
I think "Brave Software" makes the most sense, other opinions?

@aekeus
Copy link
Member

aekeus commented Jun 3, 2016

I like no spaces "Brave" but not a strong opinion

@bridiver
Copy link
Collaborator Author

bridiver commented Jun 3, 2016

That's ok too, but I remember seeing some complaint about distinguishing Brave from the Brave movie app or something like that. "Brave Software" should make it clear

@aekeus
Copy link
Member

aekeus commented Jun 3, 2016

That makes sense. "Brave Software" is more specific.

@luixxiul
Copy link
Contributor

luixxiul commented Jun 4, 2016

How about placing it in C:\Program Files\Brave Software?

@bbondy
Copy link
Member

bbondy commented Jun 4, 2016

Where do you see a Brave Inc folder?

screenshot 2016-06-04 07 47 01

screenshot 2016-06-04 07 47 14

Electron winstaller (the component we use) doesn't support installing in Program files right now. Also moving it into a higher integrity folder will mean we need to have a UAC prompt on each update which we don' want. Or install a second NT service like Mozilla has or tie into the windows task scheduler. All probably overshadowed by other priorities right now.

@bsclifton
Copy link
Member

@bridiver do you know if this is still an issue?

Recent installs on Windows are showing for me in:
%userprofile%\AppData\Local\brave

with session data stored in:
%appdata\brave%

@bridiver
Copy link
Collaborator Author

yea, that location has always been correct. Brave Inc was in the "start" menu

@srirambv
Copy link
Collaborator

Still shows Brave Inc on Windows 10 x64 #8060 (comment)

@bsclifton
Copy link
Member

@srirambv sorry I had forgotten to get you steps (the cache might be cleared by now). I'll post issues in the comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.