-
Notifications
You must be signed in to change notification settings - Fork 973
Remember full screen mode in session storage #2135
Comments
Would like to try implementing it, can I? |
yes it seems similar to this one though, so take note there for review comments: |
cc @bsclifton @bridiver in case they have any comments. |
I think we can roll all of this into a general window size restore. Maximized and Fullscreen could be represented with -1 and -2 size or something similar |
@bridiver Is @bsclifton PR on hold due to this? If so, think he can handle it better. Anyway waiting for his thoughts :) |
the PR is on hold because it will maximize every window on restore if any single window is maximized |
but if we're going to remember window size, we might as well handle all of them together |
Will definitely adjust the code per the comments 😄 |
@cezaraugusto this issue is ready for you (if you're up for it) 😄 The PR I had open has been merged: |
@bsclifton, thanks but I'm going to leave it for now, lots of work here. Feel free to keep going 👍, Anyway I'm following closely this issue. 👀 |
Awesome, I'll go ahead and grab this |
A user from support was asking why we didn't remember the full screen setting as he always wanted it to start on his page full screen.
The text was updated successfully, but these errors were encountered: