Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remember full screen mode in session storage #2135

Closed
bbondy opened this issue Jun 8, 2016 · 11 comments
Closed

Remember full screen mode in session storage #2135

bbondy opened this issue Jun 8, 2016 · 11 comments
Assignees
Milestone

Comments

@bbondy
Copy link
Member

bbondy commented Jun 8, 2016

A user from support was asking why we didn't remember the full screen setting as he always wanted it to start on his page full screen.

@cezaraugusto
Copy link
Contributor

Would like to try implementing it, can I?

@bbondy
Copy link
Member Author

bbondy commented Jun 8, 2016

yes it seems similar to this one though, so take note there for review comments:
#2029

@bbondy
Copy link
Member Author

bbondy commented Jun 8, 2016

cc @bsclifton @bridiver in case they have any comments.

@bridiver
Copy link
Collaborator

bridiver commented Jun 8, 2016

I think we can roll all of this into a general window size restore. Maximized and Fullscreen could be represented with -1 and -2 size or something similar

@cezaraugusto
Copy link
Contributor

@bridiver Is @bsclifton PR on hold due to this? If so, think he can handle it better. Anyway waiting for his thoughts :)

@bridiver
Copy link
Collaborator

bridiver commented Jun 8, 2016

the PR is on hold because it will maximize every window on restore if any single window is maximized

@bridiver
Copy link
Collaborator

bridiver commented Jun 8, 2016

but if we're going to remember window size, we might as well handle all of them together

@bsclifton
Copy link
Member

bsclifton commented Jun 8, 2016

Will definitely adjust the code per the comments 😄

@bsclifton bsclifton assigned bsclifton and unassigned bsclifton Jun 9, 2016
@bsclifton
Copy link
Member

bsclifton commented Jun 12, 2016

@cezaraugusto this issue is ready for you (if you're up for it) 😄 The PR I had open has been merged:
#2029

@cezaraugusto
Copy link
Contributor

@bsclifton, thanks but I'm going to leave it for now, lots of work here. Feel free to keep going 👍, Anyway I'm following closely this issue. 👀

@bsclifton
Copy link
Member

Awesome, I'll go ahead and grab this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants