Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Vertical tabs #2185

Closed
luixxiul opened this issue Jun 14, 2016 · 42 comments
Closed

Vertical tabs #2185

luixxiul opened this issue Jun 14, 2016 · 42 comments
Labels
design A design change, especially one which needs input from the design team. feature/tabsbar needs-mockup A feature which needs design mockup to be implemented. open-in-brave-core suggestion wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 14, 2016

Moving <TabsToolbar> inside of the .mainContainer in main.js makes it possible to get the vertical bar as follows (with some quite simple css tweaks). Here's a rough idea:

Is there any chance to implement this as an option?

Spec should be:

  • This feature should be added as an option
  • The width of the tab bar should be changeable with a mouse
  • The max number of the opened tabs should be unlimited (no tab pages should appear)
  • Tabs should be set in a tree style (cf: https://addons.mozilla.org/ja/firefox/addon/tree-style-tab/)
  • The hamburger icon should be placed on the right of the browser (left/below of the lion icon)
  • The new tab button should be placed at the bottom of the tab bar/the last opened tab
@bbondy
Copy link
Member

bbondy commented Jun 14, 2016

cc @bradleyrichter I think adding an option makes sense. I think the hamburger button should probably go to the right of the bookmarks toolbar in that case though. Not sure where the new tab button would go.

@bradleyrichter
Copy link
Contributor

Needs some new UI thinking but it would be great to have the vertical option.

Pinned tabs should be integrated into this side panel so we can hide the original tabs bar.

The Burger menu will need a new home. Perhaps 3 stacked dots to the right of the Brave button when the vertical tabs are enabled. (since the bookmarks bar can be hidden)

I won't have time for this for a bit. Maybe before 1.0 release. Certainly for 1.1.

@ghost
Copy link

ghost commented Jun 16, 2016

Side tabs are a great feature for power users. Would be even better to have tree styled tabs or also an option to have tabs at the very browser bottom for example like Yandex browser offers this lately.

Anyway, more tab bar location/styling options would be much appreciated from power users!

@dogancelik
Copy link

Hamburger menu and Brave icon should be next to each other on Vertical tabs mode
New tab icon should be centered with full width.

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Jul 13, 2016
@luixxiul luixxiul added this to the 1.1.0 milestone Jul 17, 2016
@luixxiul
Copy link
Contributor Author

Setting a milestone just as a memo..

@luixxiul luixxiul mentioned this issue Jul 28, 2016
@diracdeltas
Copy link
Member

This is awesome, thanks @luixxiul for trying this out! For me, the best feature of Firefox's tree-style tabs addons was that child tabs would show up nested under their opener tabs. Made it much easier to organize/prune.

@ghost
Copy link

ghost commented Jul 28, 2016

Tree-style-tabs... guys, add that and you get a big number of Firefox users who are frustrated with the browser :D

@bbondy
Copy link
Member

bbondy commented Jul 28, 2016

For tree style, each opened tab/frame has a key and some have a parentFrameKey. This allows for a recursive traversal.

@luixxiul luixxiul added the hackathon Legacy label for a hackaton. label Sep 23, 2016
@DeltaZone
Copy link

Tree-style tabs are crucial. We work so often on laptop screens where the screen estate space of the height is more critical than the width, so better to have them along the side, preferably also in a collapsible show/hide toggle panel. As it is now, I also miss an option to toggle hide/show of the horizontal tabs bar AND also the URL bar. This browser is wasting two whole lines that are not needed during the time we are working on or reading a web page. Even in so-called FullScreen mode, those do not go away, rendering the Fullscreen mode almost useless.

(Remember that easily available toggle functions are needed when implementing such features. It will be annoying if it is cumbersome to use an otherwise useful feature. Both a toggle button and a customizeable keyboard shortcut is needed.)

@DeltaZone
Copy link

FYI - The lack of this feature means I will not be using this browser for much. Only as a spare browser to open some special links/pages in that I do not want to risk disturbs anything in other browsers.

@luixxiul
Copy link
Contributor Author

Though I have set the milestone to 1.1.0, the feature is so wanted that it will be enabled as soon as it is developed enough.

@clopez
Copy link

clopez commented Oct 27, 2016

Please, check tabkit2 extension as an inspiration.

It is an improved three-style-tab extension that automatically assigns colors to each tab group and has a search box. See the screenshot

@ajvsol
Copy link

ajvsol commented Nov 1, 2016

Tab Center has also done this rather well (see here for the full overview).

There are ways to improve it further by incorporating both of the aforementioned [1] Tree Style Tabs and [2] Tabkit 2 also.

When browsing it just displays the favicon ([1] which would make it much easier to incorporate tree-style tabs with as it takes up so little width space, which is the biggest limitation to tree-style tabs).

Rolling over with mouse opens it up...

Until you get a full open preview of a tab

[2] also the background of each tab could have a different colour to further highlight the "tab groups".

Or do tab groups in a Tab Center's style:

Furthermore by having a defined set of tab groups in the codebase, it makes it easier to add similar tab-grouping styles such as Tab Groups Helper and Tab Outliner.

@dobriai
Copy link

dobriai commented May 4, 2017

I don't care so much if it is tree-style tabs, but I absolutely need vertical tabs, for sure. What Vivaldi has is good enough for me. Until such time, I'll stick to Firefox or Vivaldi. Lack of vertical tabs is a show-stopper for me.

@Darkless012
Copy link

I agree that what has Vivaldi (or to say also old Opera) is good enough, and also simple enough. Tree style tabs had quite a lot of bugs when I was using it. Although it would be nice to have "tree tabs", I think that just have simple "vertical tabs" would be sufficient for most cases. And then it could go from there.

@nk8020
Copy link

nk8020 commented Jul 23, 2017

I think the code is almost directly available from the firefox 'tree-style tabs' xpi (certainly controlling the width/ tree view/ hide/auto-hide...) No real reason why it should not work with minimal changes in Brave.

@fabricedesre
Copy link

I think the code is almost directly available from the firefox 'tree-style tabs' xpi (certainly controlling the width/ tree view/ hide/auto-hide...) No real reason why it should not work with minimal changes in Brave.

tree-style-tabs relies on Firefox internals so it's not really portable. In any case I think that with screens having a lot of horizontal real estate but comparatively less vertical, this should be part of the default UX options of a modern browser. For sure this can start simple with just a vertical list of tabs (and pinned ones at the top!), and evolve from here.

@diracdeltas diracdeltas removed the hackathon Legacy label for a hackaton. label Aug 3, 2017
@diracdeltas
Copy link
Member

+1 for prioritizing this for an upcoming release since Tree-Style Tabs are virtually useless in Firefox now

https://twitter.com/lyon01_david/status/933099035593818112

@luixxiul luixxiul added the needs-mockup A feature which needs design mockup to be implemented. label Nov 22, 2017
@luixxiul
Copy link
Contributor Author

It just took me ~10 min. to create the vertical tabs bar on the 1st post, though the thing has changed and today it must take more time to implement that (at that time we did not have the tear off tabs function and pinned tabs IIRC).

@eljuno
Copy link
Contributor

eljuno commented Jan 29, 2018

@JGJP
Copy link

JGJP commented Jan 30, 2018

Firefox has a revamped Tree Tabs extension that's even better than the previous Tree-Style Tabs extension, many of the users of this feature are power users that care about privacy and the other perks that Brave offers. If Brave want increased market share, I suggest the team look at implementing this feature, as even a mildly workable alternative to horizontal tabs will lead to a sizeable increase in new users.

@jxpy
Copy link

jxpy commented Feb 1, 2018

Brave must be about cutting-edge innovation to have followers. Your early adopters are obviously power users and Brave must attract them, so be 'brave' and don't shy off from adding powerful features.

Tree tabs in general are the future for landscape monitors, they optimize space and organize content.
Vivaldi i.e. has native vertical tabs, but it can also support kroppy's excellent "Tree Tabs" extension.

Brave could implement a native vertical tab feature and give extensions devs enough api freedom to implement something like Tree Tabs as an extension.

Tree Tabs example on Vivaldi:

vivaldi-tree-tabs

@NumDeP
Copy link

NumDeP commented Feb 4, 2018

I've only just noticed FF's built-in feature at the top right hand corner where you can view tabs in a list quite neatly actually, this was probably in relation to disabling Tab Center though it's still offered as Tab Center Redux in the Add-On store.
Perhaps you can take a couple of notes from this as well so most of the window space isn't removed.

screenshot

@trailblazing
Copy link

Tree Style is just an entrance of knowledge management.
The style itself is nothing. What you need is a personal knowledge assistant, memory management, sharing management, etc.

@JGJP
Copy link

JGJP commented Feb 14, 2018

Even if that was true (which it's not, imo) Tree Tabs is still the best solution.

@trailblazing
Copy link

@trailblazing
Copy link

trailblazing commented Feb 15, 2018

A new browser window (a tabs group) for a new topic which links to a social media can be handled with limited tabs showing up and with more tabs in a tree structure as a back-end data. And you just need several this kind of windows normally. I put them together because they share the same back-end tabs tree :)

@eljuno
Copy link
Contributor

eljuno commented May 27, 2018

+1 from community https://community.brave.com/t/vertical-tabs-or-equivalent-request/22788?u=eljuno

Like vertical tabs extension in Firefox.

@JackOfAllGames
Copy link

+1 here. I was just checking to see if this was possible yet. Sad to see that it's been in limbo this long. I'd love to be able to replace Firefox, but vertical tabs in SOME FORM are essential for me. I'm not all that picky. If scope creep is holding this up, I'd be plenty happy with something basic.

@Jasperki
Copy link

+1 - this and support for KeePassXC new Browser Integration are what holds me back from using Brave.

@bsclifton
Copy link
Member

I am fairly certain that we won't be able to make this feature happen with our current codebase (Muon). However, it's clear this is a great idea 😄 Since we're moving over to Brave Core, I created an issue there to track this feature request. Please give it a +1 or leave feedback 😄

brave/brave-browser#464

@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 2, 2018
@bsclifton bsclifton added wontfix post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). labels Jul 2, 2018
@bsclifton bsclifton added wontfix and removed wontfix labels Jul 13, 2018
@bsclifton bsclifton added open-in-brave-core and removed post-v1 We don't expect to be able to resolve this before releasing v1.0 with Brave Core (instead of Muon). labels Aug 13, 2018
@SirCaldude
Copy link

Still no Vertical tabs? Haven't used this browser since I installed it. Vertical Tabs in the sidebar is an absolute necessity. I can't believe anyone was stupid enough to create horizontal tabs in the first place. Dumbest idea ever.....makes absolutely NO SENSE. The only software I ever paid for was the iRider browser back in 2000....they were the first to use Vertical tabs and I won't use ANY browser that doesn't have them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/tabsbar needs-mockup A feature which needs design mockup to be implemented. open-in-brave-core suggestion wontfix
Projects
None yet
Development

No branches or pull requests