Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Auto removal of ~/.electron? #2344

Closed
luixxiul opened this issue Jun 30, 2016 · 6 comments
Closed

Auto removal of ~/.electron? #2344

luixxiul opened this issue Jun 30, 2016 · 6 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 30, 2016

Is there any way of either telling users do rm -rf node_modules/ && rm -rf ~/.electron or removing them automatically if needed?
#1098, #1550, #2140, etc.

@bbondy
Copy link
Member

bbondy commented Jun 30, 2016

I think we can at least make sure the user has no .electron on npm install.
Set a preinstall script in npm and remove it. We might need to run a script and then do it differently per platform where rm -Rf ~/.electron doesn't work. I don't think we want to auto remove node_mododules, but maybe we can figure out some kind of messaging to tell them somehow.

@luixxiul
Copy link
Contributor Author

Another case #4939

@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

#4939 is not a case of this. We don't re-use version numbers anymore so I don't think there is a benefit of this anymore.
With all of npm if you npm install on top of a dependency that is already installed, it does not update the dependency.

@bbondy bbondy added the wontfix label Oct 19, 2016
@bbondy bbondy closed this as completed Oct 19, 2016
@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

This issue was only a real problem when we tried to stay in sync with the upstream electron version numbers and re-used the same version number.

@luixxiul
Copy link
Contributor Author

Sorry I'm a bit confused. So we don't need to delete ~/.electron even if brave/electron was updated, am I right?

@bbondy
Copy link
Member

bbondy commented Oct 20, 2016

that is right, it doesn't need to be updated because the files in that folder are named with the electron version. And for all electron changes we now update the electron version now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants