Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Notification bar for crashes does not dismiss #2617

Closed
bbondy opened this issue Jul 20, 2016 · 3 comments
Closed

Notification bar for crashes does not dismiss #2617

bbondy opened this issue Jul 20, 2016 · 3 comments
Assignees
Milestone

Comments

@bbondy
Copy link
Member

bbondy commented Jul 20, 2016

If you get a renderer crash there is a notification bar at the top with an OK button.
Clicking on OK does nothing and keeps the bar.

No error in console.

cc @bridiver

@bbondy bbondy added this to the 0.11.2dev milestone Jul 20, 2016
@bridiver
Copy link
Collaborator

it appears that this worked previously because of a bug related to handling NOTIFICATION_RESPONSE in multiple places and calling hideMessageBox(message) for messages that actually shouldn't have been handled there. Seems like it would be better to handle them in one place and register callbacks. That would make it much easier to implement a default behavior and would prevent inadvertent closing of messages by other handlers.

@luixxiul
Copy link
Contributor

luixxiul commented Aug 4, 2016

Fixed ;-)

@bridiver
Copy link
Collaborator

bridiver commented Aug 4, 2016

tried to create an automated test for this, but webdriver doesn't like it when you crash the renderer process

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants