Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clone tab on different tab always clones the active tab #2787

Closed
srirambv opened this issue Jul 29, 2016 · 9 comments
Closed

Clone tab on different tab always clones the active tab #2787

srirambv opened this issue Jul 29, 2016 · 9 comments
Milestone

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Clone tab on different tabs always clones the first cloned tab

Expected behavior:
Clone tab should clone the specific tab on which the option was selected.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.11.2 Dev Beta1
  • Steps to reproduce:
    1. Clone from an existing tab
    2. Cloned tab opens next to the original tab
    3. Clone a new tab which is already open
    4. The same cloned tab opens again rather than the new tab on which clone was selected.
  • Screenshot if needed:
  • Any related issues:
@luixxiul
Copy link
Contributor

Is it the same even though you navigate to a different page on the opened tab? If so it sounds like a problem.

@srirambv
Copy link
Collaborator Author

No if navigated to different page then there is no problem. But if you clone a tab and don't navigate to any other page but try to clone a different tab then it still clones the first tab.

@srirambv
Copy link
Collaborator Author

Clone tab is working only on active tab not the other tabs. Even if you clone other tab it opens a clone tab of the active tab.

@luixxiul
Copy link
Contributor

I confirmed it too. Linking to #2768

@bbondy bbondy added this to the 0.11.2dev milestone Jul 29, 2016
@bbondy bbondy changed the title Clone tab on different tab always clones the first cloned tab Clone tab on different tab always clones the active tab Aug 1, 2016
@bbondy bbondy closed this as completed in f6f28d6 Aug 1, 2016
@alexwykoff
Copy link
Contributor

I'm seeing some slightly unexpected behavior on this one. Tested with 275a343

attack_of_the_clones

@luixxiul
Copy link
Contributor

luixxiul commented Aug 1, 2016

An inactive tab cannot be cloned actually until I select the tab and make it active.

@luixxiul luixxiul reopened this Aug 1, 2016
@bbondy
Copy link
Member

bbondy commented Aug 2, 2016

that's a valid bug and has to do with cloning unloaded tabs but is out of scope for this task, please file a new task for that. Nice find!

@bbondy bbondy closed this as completed Aug 2, 2016
@bbondy
Copy link
Member

bbondy commented Aug 2, 2016

assuming this is only for unloaded tabs like @luixxiul said? If not pls re-open.

@luixxiul
Copy link
Contributor

luixxiul commented Aug 2, 2016

@bbondy yes exactly :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants