Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

location.reload() does not reload the page title #2798

Closed
luixxiul opened this issue Jul 29, 2016 · 10 comments
Closed

location.reload() does not reload the page title #2798

luixxiul opened this issue Jul 29, 2016 · 10 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 29, 2016

Describe the issue you encountered: location.reload() does not reload the page title.

Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.11.2 Beta1
  • Steps to reproduce:
    1. Open devtool from Inspect Element in the context menu
    2. location.reload()
  • Screenshot if needed:
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Jul 29, 2016

I think when the page has no title?

@luixxiul
Copy link
Contributor Author

But https://github.com/notifications has the title "Notifications" and it is displayed until I click the bell.

@neeklamy
Copy link
Contributor

neeklamy commented Jul 30, 2016

I’ve created a Plunker to demonstrate the issue, the problem arises with links that point to the page that we are already on (anchor links are fine though),
http://run.plnkr.co/plunks/XG9Wt19x0zvMF3WM78rR/

Brave tab title breaks

@luixxiul
Copy link
Contributor Author

FYI reloading with the button next to the URL bar does work.

@srirambv
Copy link
Collaborator

srirambv commented Aug 2, 2016

One observation is when this happen is the URL bar doesn't auto hide. Also this happens when the Block script is enabled/disabled. (0.11.2 Dev Beta 2 install)

@bbondy
Copy link
Member

bbondy commented Aug 2, 2016

Is this diff from 0.11.1?

@neeklamy
Copy link
Contributor

neeklamy commented Aug 2, 2016

Is this diff from 0.11.1?

I’m still using 0.11.1, it’s the same.

@willy-b
Copy link
Contributor

willy-b commented Aug 4, 2016

The absolute link in @neeklamy's Plunker repros the bug for me on Ubuntu 14.04 for recent master (commit 9213bf0).

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 6, 2016

The easiest way to reproduce this:

  1. Open devtool
  2. location.reload()

@luixxiul luixxiul changed the title Title on tab is replaced with URL location.reload() does not reload the page title Aug 6, 2016
@bbondy bbondy modified the milestones: 0.11.4dev, 0.11.5dev, 0.11.6dev Aug 7, 2016
@bbondy bbondy modified the milestones: 1.1.0, 0.11.6dev, 1.0.0 Aug 23, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 23, 2016

This seems to have been fixed with #3202. I cannot confirm this issue in 0.11.6 beta2, so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants