Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Saving a page should default to title as filename #3041

Closed
gulkily opened this issue Aug 8, 2016 · 7 comments
Closed

Saving a page should default to title as filename #3041

gulkily opened this issue Aug 8, 2016 · 7 comments
Labels
duplicate Issue has already been reported

Comments

@gulkily
Copy link

gulkily commented Aug 8, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When saving a page with File|Save, the default filename is part of the URL.

Expected behavior:
The filename should default to the page title, if there is one.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.11.3
  • Steps to reproduce:
    1. Open a page that has a title
    2. From the menubar, select File|Save, or press Ctrl+S/Cmd+S

Expected: Filename defaults to page title

Actual: Filename defaults to the filename or domain in the URL

  • Screenshot if needed:

image

image

@luixxiul
Copy link
Contributor

luixxiul commented Aug 9, 2016

Duping to #2231

@luixxiul luixxiul closed this as completed Aug 9, 2016
@gulkily
Copy link
Author

gulkily commented Aug 16, 2016

Could you please consider reopening this issue?

I know that you wrote in #2231 that it would be a security issue, but this is the standard behavior in other browsers, so there must be a way of sanitizing the page title and adding the ".html" extension before suggesting the filename.

@luixxiul
Copy link
Contributor

luixxiul commented Aug 16, 2016

The title of the issue #2231 "Title should be default file name when saving page" is duping, isn't it?

this is the standard behavior in other browsers

No, it is not. On Firefox,

clipboard01

#2729

@luixxiul
Copy link
Contributor

The issue of detecting the file extension (.html) has been reported here #1985 fyi

@gulkily
Copy link
Author

gulkily commented Aug 16, 2016

In the screenshot you provided, the Google home page, which has the title "Google", is being saved as "Google.html", which is exactly the behavior I am requesting.

For clarity, here is a different screenshot from Firefox. As you can see, the page title makes its way into the suggested filename field (green arrows.) This screenshot also demonstrates the filename sanitation, with the slash in the title being replaced with an underscore (blue arrows.)

image

Here is another example, Chromium on Linux. In this case, the slash is replaced with a space instead of an underscore, which looks nicer in my opinion (pink arrows.)

image

Compare to Brave:

image

@gulkily
Copy link
Author

gulkily commented Aug 16, 2016

Oops, I thought the other issue was also closed...

@luixxiul
Copy link
Contributor

So doesn't we need to reopen the issue here, right?

If you think the filename sanitization should be implemented, would you please open another issue? It might be off-topic here.

@luixxiul luixxiul added the duplicate Issue has already been reported label Aug 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

2 participants