Entries in Bookmarks menu and History menu don't have favicons

[bsclifton]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Links inside the Bookmarks menu and History menu don't have favicons

Favicons are not an easy win unfortunately. Because they go into the native menubar, they have to be loaded as a nativeImage object. This means we'd have to fetch each icon, render it using canvas, and then create a nativeImage object from the base64 (or something similar).

If we had an async favicon loader (which cached the icons) this might be easier. Once the favicon gets loaded, it could update the application state (which would then automatically trigger the menus to re-render).

Expected behavior:
Links inside the Bookmarks menu and History menu should have favicons. Here's a picture that @bradleyrichter had created for this issue:

• Any related issues:
  • List bookmarks like other browsers - Bookmarks Menu should list the bookmarks like other browsers do #1993
  • Favicon cache - Cache favicons (to prevent fetching each time Brave is reloaded) #2697
  • Favicons in bookmark list - about:bookmarks should show favicon for each item #1994

[bsclifton]

+1 from support (captured in #5983)

[alexwykoff]

+1 from support @bradleyrichter my user in particular asked for icons on the bookmarks toolbar as well to denote folders as the '>' was too subtle.

[cndouglas]

@alexwykoff Don't we already have favicons for the bookmarks toolbar? Maybe favicons are turned off in the user's preferences.

[bradleyrichter]

@alexwykoff We can increase the visual weight of the down-carrot, and otherwise send them to prefs as @liunkae points out..... : )

[cndouglas]

@bradleyrichter By the way, do you think favicons in the bookmarks bar should be turned on by default? I think the default right now is text only.

[bradleyrichter]

I was inspired by the clean look of the Safari BM bar.

If we find out that most users prefer the clutter of favicons everywhere, we can change the default, and I will enjoy my personal preference of purity, under the tree on a grass hill, with a nice Chianti. (and maybe some fava beans)

[ColinMcKay004]

Thanks gents, Liunkae correct - Mr Luddite & new Brave user here was unaware of Preferences option for Favicons.