This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
History follow up #3253
Merged
History follow up #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would you mind rebasing this? It looks like there is a conflict to merge. I still haven't reviewed though btw. |
- about:history now supports context menu (shares code w/ bookmarks) - added isBookmark to siteUtil and updated code to use it - fixed comment on UPDATE_MENU_BOOKMARKED_STATUS - Delete history item now works - Broke out common styles (between history and bookmarks about pages) to siteDetail.less, updated both to use it - Sending menu update (via IPC) only sends what's needed; needs to be refactored to live in appState - Updated directory structure for menu, menuUtil, and commonMenu per https://github.com/brave/browser-laptop/blob/master/docs/directoryStructure.md
|
@bbondy done 😄 |
|
++ |
This was referenced Aug 21, 2016
This was referenced Aug 23, 2016
This was referenced Aug 25, 2016
This was referenced Aug 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #3206
cc: @bridiver @bbondy
The only thing not addressed are the IPC calls. I definitely agree we can move:
and more into AppStore (and then we'd just use actions). Those changes are "bigger than a breadbox" so I left them out of this PR.
Here's what's fixed: