Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reduced specificity of select class in css #3282

Closed
rohanthacker opened this issue Aug 20, 2016 · 1 comment
Closed

Reduced specificity of select class in css #3282

rohanthacker opened this issue Aug 20, 2016 · 1 comment
Assignees
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS
Milestone

Comments

@rohanthacker
Copy link

rohanthacker commented Aug 20, 2016

Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
The style of select element used is deeply nested under settings

Expected behavior:
Reduce code duplications by assigning classes, similar to the pattern used in other elements, For Eg : button.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    11.3
  • Steps to reproduce:
    1. Improve UI/UX of bookmark popup #2894 , Required Dropdown for Bookmarks
    2. Select Element used in Brave Menu
    screen shot 2016-08-21 at 3 29 45 am

3.Select Element Used in Settings, similar to bookmarks but nested under settings classes.
screen shot 2016-08-21 at 3 29 56 am

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Sep 22, 2016
@bradleyrichter
Copy link
Contributor

the brave menu should ideally use the in-page style for popup menus.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS
Projects
None yet
Development

No branches or pull requests

5 participants