This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Updates to history page: #3320
Merged
Updates to history page: #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Style refresh (fairly close to mockup) - changed color of about:history tab - Page now breaks history items down by date (sorted desc) - shortened location shown to "domain.tld" - page is now localized (including formatting dates) - added working "Clear browsing data button" - history is now searchable (also broken down by date) - updated page to use SortableTable Fixes #441 Updates to SortableTable control: - renamed hoverCallback and isHover, giving a more clear name - extended to allow optional classnames per column - can process onClick, onDoubleClick, and onContextMenu - new `rowObjects` property, useful for mapping a row to the raw object
|
@bsclifton pls audit my commit |
|
++ |
|
Changes look great! 👍 Thanks for reviewing and finding/fixing those items 😄 |
This was referenced Aug 25, 2016
This was referenced Aug 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441
Updates to SortableTable control:
rowObjectsproperty, useful for mapping a row to the raw object