Update test fails

[luixxiul]

Describe the issue you encountered: Test that updating using BRAVE_UPDATE_VERSION=0.8.3 env variable does not works correctly.

Expected behavior:

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit, Windows 7 64 bit
• Brave Version: 0.11.6 beta2
• Steps to reproduce:
  1. Set the variable BRAVE_UPDATE_VERSION=0.8.3 and restart the browser
  2. Check update manually from the hamburger menu
• Screenshot if needed:
  
• Any related issues: Manual tests for Win-x64 0.11.6 beta3 #3362 Manual tests for Win-ia32 0.11.6 beta3 #3363

Setting a milestone for now.

[bbondy]

@aekeus fixed this here:
57b7dc0

[aekeus]

grep -r 'request(' * | grep -v extensions

ledger.js: request.request({ url: url, responseType: 'blob' }, (err, response, blob) => {
ledger.js: request.request(options, (err, response, body) => {
updater.js: request(queryString, (err, response, body) => {

It looks like we only use the request call in the updater and ledger - so we should be all good.

[aekeus]

Tested this on OSX and Win10. OSx is working as expected Windows is not retrieving metadata from the update server.

[aekeus]

More details - MacOS is updating correctly. Windows is retrieving metadata in dev, but not in the RC4 release.

2016-08-26T19:38:07.478Z - checkForUpdates
2016-08-26T19:38:07.478Z - lastCheckYMD = 2016-08-26
2016-08-26T19:38:07.478Z - lastCheckWOY = 34
2016-08-26T19:38:07.478Z - lastCheckMonth = 8
2016-08-26T19:38:07.478Z - firstCheckMade = true
2016-08-26T19:38:07.478Z - https://brave-laptop-updates.global.ssl.fastly.net/1/releases/dev/0.8.3/winx64?daily=false&weekly=false&monthly=false&first=false
2016-08-26T19:38:07.853Z - Metadata: {"version":"0.11.5","name":"Brave 0.11.5","pub_date":"2016-08-15T18:31:32.610Z","notes":"Stability and minor bug fixes. More details: https://github.com/brave/browser-laptop/releases/tag/v0.11.5dev\n\nMore data clearing options, tab page previews, printing fix on Windows, memory leak fixes, crash fixes and more: https://github.com/brave/browser-laptop/releases/tag/v0.11.4dev\n\nPDF, zoom, URL bar fixes, and libchromiumcontent 52.0.2743.116. Full details: https://github.com/brave/browser-laptop/releases/tag/v0.11.3dev\n\nLong tap history on back button, search shortcuts like 'yt cat videos', tab and nav cloning, and much more: https://github.com/brave/browser-laptop/releases/tag/v0.11.2dev\n\nPDF viewing, more data clearing options, navigator.registerProtocolHandler support, copy image option and more: https://github.com/brave/browser-laptop/releases/tag/v0.11.1dev\n\nLastPass support, WebRTC fingerprinting protection, Flash click to play if Flash is enabled, and more: https://github.com/brave/browser-laptop/releases/tag/v0.11.0dev\n\nAutocomplete, new suggestions UX, experimental Flash support and more: https://github.com/brave/browser-laptop/releases/v0.10.4dev\n\nUpdate to libchromiumcontent 51.0.2704.84\n\nCrash fix for Windows with some link types.\n\nFingerprint protection in the Bravery panel and various fixes. Full notes: https://github.com/brave/browser-laptop/releases/v0.10.1dev\n\nPer site Bravery panel, error pages, and much more. Full detail: https://github.com/brave/browser-laptop/releases/tag/v0.10.0dev\n\nChromium 50.0.2661.102 and various bug fixes. Full details: https://github.com/brave/browser-laptop/releases/tag/v0.9.6dev\n\nSpell check, script blocking similar to NoScript, and much more. Full details: https://github.com/brave/browser-laptop/releases/tag/v0.9.5dev\n\nStartup fix if profile dir does not exist\n\nDashlane support, external protocol handling, permission prompts, Chromium 50.0.2661.86, and more\n\nWindows 32-bit support, Windows default browser handling, fingerprinting protection, zoom fixes, multi language support, printing fix, and more. Full details: https://github.com/brave/browser-laptop/releases/tag/v0.9.2dev\n\nVarious fixes. Full details: https://github.com/brave/browser-laptop/releases/tag/v0.9.1dev\n\n1Password support, malware protection, phishing protection and more. Details: https://github.com/brave/browser-laptop/releases/tag/v0.9.0dev"}
2016-08-26T19:38:07.853Z - Error: Can not find Squirrel
2016-08-26T20:01:07.492Z - platformBaseUrl = https://brave-laptop-updates.global.ssl.fastly.net/1/releases/dev/0.8.3/winx64
2016-08-26T20:01:07.492Z - updateUrl = https://brave-download.global.ssl.fastly.net/multi-channel/releases/dev/winx64
2016-08-26T20:01:25.382Z - checkForUpdates
2016-08-26T20:01:25.382Z - lastCheckYMD = 2016-08-26
2016-08-26T20:01:25.382Z - lastCheckWOY = 34
2016-08-26T20:01:25.382Z - lastCheckMonth = 8
2016-08-26T20:01:25.382Z - firstCheckMade = true
2016-08-26T20:01:25.382Z - https://brave-laptop-updates.global.ssl.fastly.net/1/releases/dev/0.8.3/winx64?daily=false&weekly=false&monthly=false&first=false
2016-08-26T20:01:25.731Z - null

[bbondy]

looks like this message is displayed when you don't have access to the udpater.exe

https://github.com/electron/electron/blob/01f92a83ab83001a48644a32e2cfcfe569ef13c6/lib/browser/api/auto-updater/auto-updater-win.js#L29

https://github.com/electron/electron/blob/01f92a83ab83001a48644a32e2cfcfe569ef13c6/lib/browser/api/auto-updater/squirrel-update-win.js#L108

Maybe your VM just needs a reboot?

[bbondy]

I'm thinking due to locked file

[aekeus]

Yup, just tested on latest RC. Works as expected now.

[luixxiul]

On the 0.11.6 beta5 still I have the same error on Windows 7 64 bit.

[bbondy]

Did you mean beta5 @aekeus ?

[bbondy]

@luixxiul did you try rebooting and then testing? Please send a new update log after rebooting if it still fails.

[bbondy]

Re-opening for now since @luixxiul said something is still up

[aekeus]

I tested this again on Win 10 64-bit. To ensure I had the latest version I deleted my brave folder within AppData\Local and reinstalled beta5.

[aekeus]

It would be good to get an independent verification before I close this, so waiting.

[bbondy]

@alexwykoff please try this one

[luixxiul]

It works now on the latest beta on Windows 7 64 bit! I think it is OK to close this 👍