This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Adding bookmark will now properly update title + rendering fix #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review |
bsclifton
changed the title
- reverted change to addEditBookmark (not needed) - updated logic in siteUtil::addSite; new title is always used - updated tests accordingly - updated logic in bookmarks toolbar rendering. fixes #3080
|
++ feel free to also review @BrendanEich, I want to merge to get it in beta3 builds though for 0.11.6. |
This was referenced Aug 25, 2016
This was referenced Aug 25, 2016
This was referenced Aug 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.Before, adding a bookmark that existed before (and had been removed) would cause the new bookmark to use the old title. Changes here fix #3284
Bookmarks Toolbar component was not considering the customTitle for a siteDetail when rendering. Also updated to default to location if title or customTitle are null. Fixes #3080
Auditor: @BrendanEich