Adjust layout and polish - Ledger Add Funds Dialog

[bradleyrichter]

current:

revised:

cc @jkup

[diracdeltas]

one thing to note is that the current layout has two states, depending on whether the bitcoin: URL handler has been registered. if it hasn't, it looks like the screenshot Brad posted above. if it has, it looks like this:

because you can just click transfer funds and your browser's registered bitcoin handler will automatically do the transfer.

if you don't have a registered bitcoin handler, you either have to scan the QR code or copy-paste the payment URL into an app that can handle transfers. hence why the first screenshot shows the full payment URL, not just the wallet address.

[diracdeltas]

@jkup to test this out, you can use https://jsfiddle.net/LnwtLckc/5/ to register/unregister the bitcoin: URL handler. you should see the component state change as soon as it's registered/unregistered.

[bradleyrichter]

@diracdeltas would this work for both? Then we can just drop the "Transfer bitcoin" button when the URI is not configured.

[diracdeltas]

@bradleyrichter that would probably work for the vast majority of cases. the one it doesn't cover is if you use a desktop app to handle bitcoin: URLs, so you can't scan the QR code. the point of showing the payment URL is so that you can copy it into your bitcoin app in this situation. you could still copy the wallet address and manually enter the other payment info.

i'm not sure how often this case comes up; i think most people have bitcoin apps with QR code scanners.

[bradleyrichter]

we can link the full URL under the wallet address for this case?

[diracdeltas]

@bradleyrichter sure

[mrose17]

sorry to be chiming in late. here is what we had prior to rc 1:

and here is what we have in rc 1:

my view is that what we have in rc 1 is less helpful to the new user (and not that helpful to an existing BTC user).

my suggestion is that we stick with the first image above with one change: if the browser does not have a bitcoin URI set, then replaces the "Transfer BTC" button with this text "Scan the QR code above or transfer $X to your Brave wallet." below that, keep the usual "Your Brave wallet address is..."

[bradleyrichter]

closing this since it has been replaced by a new version:

#3677