This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
use different file name for development version #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i was running under both `/Applications` and `npm run watch/npm start` and had some unfortunate interactions
This reverts commit 08e7ddc.
| @@ -132,7 +132,7 @@ var boot = () => { | |||
| if ((bootP) || (client)) return | |||
|
|
|||
| bootP = true | |||
| fs.access(statePath, fs.FF_OK, (err) => { | |||
| fs.access(pathName(statePath), fs.FF_OK, (err) => { | |||
There was a problem hiding this comment.
pathName could probably just be called only once again above instead of repeatedly below, downside is that someone could forget to call it when using statePath (which isn't actually a path) later. I'll merge though.
|
btw if something in a pull request is committed then reverted, then it should just be rebased out completely and not included in the pull request. |
|
You can do that with an interactive rebase for future ref: |
This was referenced Aug 27, 2016
This was referenced Aug 31, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was running under both
/Applicationsandnpm run watch/npm startand had some unfortunate interactions
auditor: @bbondy