Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledger should check bitcoin handler for a specified session #3625

Closed
diracdeltas opened this issue Aug 31, 2016 · 5 comments
Closed

ledger should check bitcoin handler for a specified session #3625

diracdeltas opened this issue Aug 31, 2016 · 5 comments

Comments

@diracdeltas
Copy link
Member

instead of assuming session is ''

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

all the sessions should be in sync as far as I recall so checking any is fine.

@bridiver
Copy link
Collaborator

it's an easy fix. Are you passing the partition from frames.js? If so you'll call electron.session.fromPartition(partition).protocol.isNavigatorProtocolHandled('bitcoin') when the fix is ready. You can't really use the sender because the ipc message is sent from the browser window

@bridiver
Copy link
Collaborator

bridiver commented Mar 1, 2017

@bbondy won't syncing the private partition -> regular leak data about the bitcoin handler?

@bbondy
Copy link
Member

bbondy commented Mar 1, 2017

that comment was from aug 2016 so not related to sync, but it was just me thinking that the bitcoin handler was the same for all sessions. I don't think there's an api for web sties to see if something is registered. Maybe that changed though since.

@bridiver
Copy link
Collaborator

bridiver commented Mar 1, 2017

I'm more worried about anything saved in the user data dir that the bitcoin handler was registered if it was only done in a private session

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants