Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

siteUtils.clearSitesWithoutTags has misleading name #3639

Closed
bsclifton opened this issue Sep 1, 2016 · 0 comments
Closed

siteUtils.clearSitesWithoutTags has misleading name #3639

bsclifton opened this issue Sep 1, 2016 · 0 comments
Assignees
@bsclifton
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 refactoring
Milestone
0.12.0dev

Comments

@bsclifton
Copy link
Member

Feedback per https://github.com/brave/browser-laptop/pull/3501/files/dc5d3b7ad01644d918f792a7456e11a78473cb26#r76535126

siteUtils handles:

  • history
  • bookmarks
  • pinned tabs

The methods have more descriptive names, specifically the clearSitesWithoutTags method (called when you clear history).
@bsclifton bsclifton added this to the 0.11.7dev milestone Sep 1, 2016
@bsclifton bsclifton self-assigned this Sep 1, 2016
@bsclifton bsclifton mentioned this issue Sep 1, 2016
Merged
3 tasks
This was referenced Sep 4, 2016
Closed
Closed
This was referenced Sep 5, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 refactoring
Projects
None yet
Milestone
0.12.0dev
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @bsclifton @srirambv